Source: sysbench
Source-Version: 1.0.20+ds-5
Severity: normal
Tags: patch

Hi!

This package contains a long and now out-dated list of architectures
for its sysench binary package in debian/control. This is in general
not the correct approach, because it is trying to encode portability
issues for another depended on package, where that information
belongs.

Instead of removing several of the obsolete arches (such as avr32 or
m32r among others), I think it's way better to revert to use «any»,
given that the luajit2 build dependency is currently not available on
architectures where it would segfault, which means this package will
have unsatisfied build dependencies, not get built and not hinder
package migration. In addition if luajit2 gets ported to some new
arch, then this package would automatically pick that up w/o any need
for maintainer intervention. And then neither the arch list needs to
be kept up to date with additions and removals from dpkg.

Attached the proposed patch.

Thanks,
Guillem
From ad9ae368d5d146546ba7b234cabf6349138b07df Mon Sep 17 00:00:00 2001
From: Guillem Jover <guil...@debian.org>
Date: Wed, 22 Nov 2023 01:22:32 +0100
Subject: [PATCH] debian: Switch Architecture back to any

The luajit2 package has been restricted to the architectures it actually
supports, and where users should not segfault. This information is
better tracked and encoded in the package that is causing the
portability issue, and not in all of its users, which then would need to
be synced up when that status changes. Because luajit2 is not available
anymore on for example ppc64el, sysbench on that arch would be unable to
satisfy its build dependencies and not build any package which should
then not affect package migration. And in case luajit2 gets ported to
new architectures the build daemons will automatically be able to
satisfy the build dependencies and this package will then be built with
no need for maintainer intervention.

In addition the current list contained architectures that have been
removed from dpkg, and might cause problems with dak once its host
system gets updated to a new release containing that dpkg version.
---
 debian/control | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/debian/control b/debian/control
index 9057003..89b0dbc 100644
--- a/debian/control
+++ b/debian/control
@@ -23,9 +23,7 @@ Vcs-Browser: https://salsa.debian.org/jcfp/sysbench
 Rules-Requires-Root: no
 
 Package: sysbench
-# exclude ppc64el; as a convenient notation like !ppc64el isn't supported
-# here (see #807264) that amounts to listing everything else...
-Architecture: any-alpha any-amd64 any-arm64 any-armeb any-arm any-avr32 any-hppa any-i386 any-ia64 any-m32r any-m68k any-mips any-mips64 any-mips64el any-mips64r6 any-mips64r6el any-mipsel any-mipsr6 any-mipsr6el any-nios2 any-or1k any-powerpc any-powerpcel any-ppc64 any-riscv64 any-s390 any-s390x any-sh3 any-sh3eb any-sh4 any-sh4eb any-sparc any-sparc64 any-tilegx
+Architecture: any
 Depends: ${shlibs:Depends}, ${misc:Depends}
 Description: multi-threaded benchmark tool for database systems
  SysBench is a modular, scriptable and multi-threaded benchmark tool based on
-- 
2.42.0

Reply via email to