Hi, Thanks both of you for the feedback. I'm short on time at the moment but I'll make the changes you suggested, they makes sense.
And sorry for pushing this version without notice, I didn't realise other packages were using it and depended on its API. Cheers. Mathieu. On Wed, Nov 08, 2023 at 09:57:39AM +0100, Pierre Gruet wrote: > Control: severity -1 important > > Hi, > > Thanks Andrius for the advice given here. > > On Wed, 8 Nov 2023 09:44:58 +0200 Andrius Merkys <mer...@debian.org> wrote: > > Hello, > > > > On Thu, 02 Nov 2023 18:10:19 +0100 Pierre Gruet <p...@debian.org> wrote: > > > Recently catch2/3.4.0-1 was uploaded to Debian, great. Yet the > binary packages > > > do not follow the layout for libraries that is described in > Policy Section 8. > > > For instance I think we should provide a shared library and if > there are enough > > > reasons not to do so (see Policy 8.3), at least the binary > package name should > > > be changed to libcatch2-dev. > > > > > > Also this is not a header-only library anymore, the description > of the package > > > should be changed. > > > > I agree, binary package could be renamed and descriptions should be > > adapted as well. I am not sure about shared library, though. > > > > First, upstream uses full source package version for soversion. This > > means a transition for even a patch level upstream release. I maintain a > > couple of packages like this and it is tiring. > > > > Second, I do not expect any real binary package depending on catch2 > > shared library as only test objects are linked with it. But I may be > > wrong here. > > This seems like a good reason to keep a static library, at least for > the moment. > > If there remains only the renaming of the package and its > description to be changed, then downgrading the severity looks > sensible. > > > > > > As a side note, the upload of the major version 3.x came out > with many breaking > > > interface changes giving rise to RC bugs in e.g. genomicsdb, > netgen, spdlog, > > > therion just to name a few, also to failing autopkgtests in many > rdeps. I would > > > have been more comfortable with such a huge version change being > advertised and > > > more prepared, with some kind of a library transition process > for instance. > > > > Right. Such changes should be announced beforehand since catch2 is used > > widely in the archive. Transition would have been nice indeed. > > If you, Mathieu, have some insight into the best ways to transition > reverse dependencies, I think giving it in the related bug reports > would be very helpful. > > > > > > In any case, thanks for your work on catch2, > > > > Seconded - thanks for maintaining this package. > > > > Best wishes, > > Andrius > > > > > > Have a great day, > > -- > Pierre -- Mathieu Mirmont <m...@parad0x.org>
signature.asc
Description: Digital signature
