Hi, On Sun, 2023-10-29 at 23:52 +0900, Osamu Aoki wrote: > Hi, > > On Sun, 2023-10-29 at 15:11 +0530, Pirate Praveen wrote: > ... > > As you noted in subsequent comment, we can skip package.yaml. Build depends > > can be dh-sequence-nodejs instead of pkg-js-tools (npm2deb did that switch). > > Both in bookworm and sid, dh-sequence-nodejs is a virtual package offered by > dh- > nodejs. The binary package dh-nodejs is based on source package pkg-js-tools > which seems to have gone through package split. > > Although I just updated package, it may be good idea to change this to dh- > nodejs > now. > > > If dh-sequence-nodejs is in Build Deps then we don't need to add --with > > nodejs > > to dh as well. > > This seems to be redundant but I think no harm and good practice to be > explicit > to be future proof. This comes from python experience. I may be wrong. > > Osamu > >
dh-nodejs is Depends on pkg-js-tools pkg-js-tools is not Depends (only Suggests) for dh-nodejs For packaging we only need dh-nodejs So requiring pkg-js-tools is not enough... needs to be fixed.
