On Mon, Oct 02, 2023 at 02:29:34PM +0200, Chris Lamb wrote: > Whilst working on the Reproducible Builds effort [0], we noticed that > dacite could not be built reproducibly. > > This is because it shipped a bunch of nondeterminstic ~temporary build > files in the binary package, such as benchmarks (in addition to > benchmark.json) and test caches. > > Patch attached that removes them in a way paralleling the existing > removal method in debian/rules. > > [0] https://reproducible-builds.org/ > > > Regards, > > -- > ,''`. > : :' : Chris Lamb > `. `'` la...@debian.org / chris-lamb.co.uk > `-
> --- a/debian/rules 2023-10-02 14:23:18.762168493 +0200 > --- b/debian/rules 2023-10-02 14:27:11.902512609 +0200 > @@ -7,3 +7,5 @@ > override_dh_auto_install: > dh_auto_install > rm debian/python3-dacite/usr/lib/python3*/dist-packages/benchmark.json > + rm -rf debian/python3-dacite/usr/lib/python3*/dist-packages/.benchmarks > + rm -rf > debian/python3-dacite/usr/lib/python3*/dist-packages/.pytest_cache Hi, thanks for the patch, but it seems like the normal build does not contain these files, for example: File list of package python3-dacite in sid of architecture all /usr/lib/python3/dist-packages/dacite-1.8.1.egg-info/PKG-INFO /usr/lib/python3/dist-packages/dacite-1.8.1.egg-info/dependency_links.txt /usr/lib/python3/dist-packages/dacite-1.8.1.egg-info/requires.txt /usr/lib/python3/dist-packages/dacite-1.8.1.egg-info/top_level.txt /usr/lib/python3/dist-packages/dacite/__init__.py /usr/lib/python3/dist-packages/dacite/cache.py /usr/lib/python3/dist-packages/dacite/config.py /usr/lib/python3/dist-packages/dacite/core.py /usr/lib/python3/dist-packages/dacite/data.py /usr/lib/python3/dist-packages/dacite/dataclasses.py /usr/lib/python3/dist-packages/dacite/exceptions.py /usr/lib/python3/dist-packages/dacite/frozen_dict.py /usr/lib/python3/dist-packages/dacite/py.typed /usr/lib/python3/dist-packages/dacite/types.py /usr/share/doc/python3-dacite/README.md.gz /usr/share/doc/python3-dacite/changelog.Debian.gz /usr/share/doc/python3-dacite/changelog.gz /usr/share/doc/python3-dacite/copyright Not sure why whould reproducible build have these files included? -- Valentin
