* Johannes Weißl [Wed, 10 May 2006 21:29:48 +0200]:

> It seems caff has a problem with non-ASCII characters:

I confirm this problem.

> I wrote a patch that addresses the header-problem:

I'd be happy to see this patch applied, since I suffer from the same
problem and I can confirm it works. Admittedly, though, it'd be best if
the code would assume ~/.caffrc is encoded in `locale charmap` instead
of always UTF-8.

Also, TTBOMK, the following (shorter) patch is also correct (no hard
requirement to encode each word separately):

--- caff~
+++ caff
@@ -297,6 +297,7 @@
 use File::Temp qw{tempdir};
 use Text::Template;
 use MIME::Entity;
+use Encode;
 use Fcntl;
 use IO::Select;
 use Getopt::Long;
@@ -799,7 +800,7 @@
 
        $message_entity->head->add("Subject", "Your signed PGP key 0x$key_id");
        $message_entity->head->add("To", $address);
-       $message_entity->head->add("From", '"'.$CONFIG{'owner'}.'" 
<'.$CONFIG{'email'}.'>');
+       $message_entity->head->add("From", '"'.Encode::encode('MIME-Q', 
$CONFIG{'owner'}).'" <'.$CONFIG{'email'}.'>');
        $message_entity->head->add("Reply-To", $CONFIG{'reply-to'}) if defined 
$CONFIG{'reply-to'};
        $message_entity->head->add("Bcc", $CONFIG{'bcc'}) if defined 
$CONFIG{'bcc'};
        $message_entity->head->add("User-Agent", $USER_AGENT);

Thanks,

-- 
Adeodato Simó                                     dato at net.com.org.es
Debian Developer                                  adeodato at debian.org
 
                                       Listening to: Placebo - The Crawl


Reply via email to