On Tue, 26 Sep 2023 23:27:20 +0200 Johannes Schauer Marin Rodrigues <jo...@debian.org> wrote:
> Quoting David (Plasma) Paul (2023-09-26 22:25:47) > > Please accept the attached patch to add support for the <nodoc> > > build profile to mmdebstrap. Please let me know if there's anything > > you'd like me to clarify or change. > > I haven't tried your diff yet, but I've read it and it looks like it > does the right thing. Thank you! > > May I ask in which situation you found yourself wanting to build > mmdebstrap without its manual pages? It's not so much that I necessarily want to build mmdebstrap without its manpages; rather, that I find it useful to document which build dependencies are strictly needed to produce a functional program binary and which are only required to do things like generate documentation or run a testsuite. Build profiles, thus, provide an ideal way of adding this metadata in a easily actionable manner. [...] > > Also, FWIW, the mmtarfilter script contains a section of code > > headed by a comment explaining that it is for compatibility with > > Python versions older than 3.8. As the aforementioned 'match' > > statement makes the script in its current form error out with any > > Python version less than 3.10, this code path may no longer be > > necessary. > > The codepath is still necessary. What is not necessary anymore is to > explicitly pass format=tarfile.PAX_FORMAT because that format became > the default in 3.8. Ok, I wasn't sure. Thanks for confirming. > I adjusted the comment, thank you! Thank you! -- Plasma
