Source: ntpsec
Version: 1.2.2+dfsg1-2
Severity: normal
Tags: patch
User: bi...@debian.org
Usertags: nm-hook-scripts
Hi,
your package currently installs a NetworkManager hook script in
/etc/NetworkManager/dispatcher.d
This practice is no longer recommended and instead package provided hook
scripts should be moved to /usr/lib/NetworkManager/dispatcher.d
/etc/NetworkManager/dispatcher.d is meant to be used for local
modifications.
Disabling a package provided hook script is as simple as running
touch /etc/NetworkManager/dispatcher.d/$hookscriptname
Overriding a packager provided hook can also be done by providing a
script in /etc with the same name.
Attached is a patch which updates ntpsec to use this new scheme.
Please consider it in your next upload.
I can also offer to NMU the package with this change.
Regards,
Michael
diff -Nru ntpsec-1.2.2+dfsg1/debian/changelog
ntpsec-1.2.2+dfsg1/debian/changelog
--- ntpsec-1.2.2+dfsg1/debian/changelog 2023-07-30 21:04:02.000000000 +0200
+++ ntpsec-1.2.2+dfsg1/debian/changelog 2023-09-27 17:05:15.000000000 +0200
@@ -1,3 +1,11 @@
+ntpsec (1.2.2+dfsg1-2.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Move NetworkManager hook scripts to /usr/lib/NetworkManager/dispatcher.d.
+ (Closes: #-1)
+
+ -- Michael Biebl <bi...@debian.org> Wed, 27 Sep 2023 17:05:15 +0200
+
ntpsec (1.2.2+dfsg1-2) unstable; urgency=high
* copyright: Update libjsmn comment
diff -Nru ntpsec-1.2.2+dfsg1/debian/ntpsec.conffiles
ntpsec-1.2.2+dfsg1/debian/ntpsec.conffiles
--- ntpsec-1.2.2+dfsg1/debian/ntpsec.conffiles 1970-01-01 01:00:00.000000000
+0100
+++ ntpsec-1.2.2+dfsg1/debian/ntpsec.conffiles 2023-09-27 17:05:14.000000000
+0200
@@ -0,0 +1 @@
+remove-on-upgrade /etc/NetworkManager/dispatcher.d/ntpsec
diff -Nru ntpsec-1.2.2+dfsg1/debian/ntpsec-ntpdate.conffiles
ntpsec-1.2.2+dfsg1/debian/ntpsec-ntpdate.conffiles
--- ntpsec-1.2.2+dfsg1/debian/ntpsec-ntpdate.conffiles 1970-01-01
01:00:00.000000000 +0100
+++ ntpsec-1.2.2+dfsg1/debian/ntpsec-ntpdate.conffiles 2023-09-27
17:05:06.000000000 +0200
@@ -0,0 +1 @@
+remove-on-upgrade /etc/NetworkManager/dispatcher.d/ntpsec-ntpdate
diff -Nru ntpsec-1.2.2+dfsg1/debian/rules ntpsec-1.2.2+dfsg1/debian/rules
--- ntpsec-1.2.2+dfsg1/debian/rules 2023-01-17 00:31:00.000000000 +0100
+++ ntpsec-1.2.2+dfsg1/debian/rules 2023-09-27 17:02:53.000000000 +0200
@@ -169,11 +169,11 @@
install -D -m 0644 debian/ntpsec.dhcp \
debian/ntpsec/etc/dhcp/dhclient-exit-hooks.d/ntpsec
install -D -m 0755 debian/ntpsec.networkmanager \
- debian/ntpsec/etc/NetworkManager/dispatcher.d/ntpsec
+ debian/ntpsec/usr/lib/NetworkManager/dispatcher.d/ntpsec
install -D -m 0644 debian/ntpsec-ntpdate.dhcp \
debian/ntpsec-ntpdate/etc/dhcp/dhclient-exit-hooks.d/ntpsec-ntpdate
install -D -m 0755 debian/ntpsec-ntpdate.networkmanager \
-
debian/ntpsec-ntpdate/etc/NetworkManager/dispatcher.d/ntpsec-ntpdate
+
debian/ntpsec-ntpdate/usr/lib/NetworkManager/dispatcher.d/ntpsec-ntpdate
install -D -m 0644 debian/ntpsec-systemd-netif.path \
debian/ntpsec/lib/systemd/system/ntpsec-systemd-netif.path
install -D -m 0644 debian/ntpsec-systemd-netif.service \
