Package: xen-tools
Version: 1.4-2
Severity: normal

        According to the man page, the option "--volume" to xen-create-image is
the logical volume under which the root and swap for the domU will be created.
But this is a misnomer: what the programmer really means is not "logical
volume", but "volume group". So, with --volume you specify the name of the
*volume group* that you want to use, and then xen-create-image will create
*logical volumes* inside it, one for the root and one for swap.  So, in case
your VG is called vg0, you would use "--volume vg0".

        There is yet another confusing note in xen-create-image: when it ends,
it tells you how you can mount your newly created filesystem to check it out.
But it uses the syntax for loop files, even for LVs. I.e.:

        mount -o loop -t ext3 /dev/vg0/myxen-root /mnt/tmp

        When it should be simply:

        mount -t ext3 /dev/vg0/myxen-root /mnt/tmp

        I wondered why the error wasn't detected when xen-create-image
invoked lvcreate and this complained about not being capable of using the
VG given. Looking at the source of xen-image-create, it seems that it
doesn't check the return status of system commands.  In the function
runCommand, the related code is:

    $cmd .= " >/dev/null 2>/dev/null" unless $CONFIG{'debug'};

    #
    #  Run it.
    #
    my $output = `$cmd`;

        This should, IMHO, check the value of $?, and bail if it's not 0.
This should keep it from going on when there has been an error creating the
volumes or running any other command, actually. Extra points if it gives
the operator the option to "roll back" and undo every step done until the
failure, so the system is in the same state as before using
xen-create-image.

        Anyway, kudos on a superb tool. I tried to do something similar for
User Mode Linux and I know that it takes work and skills :-)

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.16-1-xen-686
Locale: [EMAIL PROTECTED], [EMAIL PROTECTED] (charmap=ISO-8859-15) (ignored: 
LC_ALL set to [EMAIL PROTECTED])

Versions of packages xen-tools depends on:
ii  debootstrap                   0.2.45-0.2 Bootstrap a basic Debian system
ii  libterm-size-perl             0.2-2      Perl extension for retrieving term
ii  perl-modules                  5.8.8-2    Core Perl modules

-- no debconf information


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to