Alberto Gonzalez Iniesta wrote:
Hi,

On upgrade, only running VPNs are restarted, that's the desired
behaviour. Those not running are down because you didn't want them up.
On upgrade they shouldn't be started then.

Sorry, but I don't understand. Are you saying that when stop2upgrade=true no VPNs should be running after the upgrade? I hope the below isn't too tedious and I'd enjoy learning why the package behaves as it does.

Here is the current behavior:

stop2upgrade=false

VPNs are left up during the upgrade and restarted by the postinst script (using cond-restart || restart). This makes sense.

stop2upgrade=true

All VPNs are stopped by the prerm script. When the postinst script runs cond-restart it refuses to start anything because nothing is running.

I don't think that leaving all VPNs off is the desired behavior. If it is, could that be made more clear in the debconf template? It is clear that if you answer no then VPNs will be restarted after upgrade. Clearly, answering yes means they will be stopped before the upgrade but nothing is said about restarting them. To me it is surprising that they should be left off so this should be said explicitly if that is the intent.

I can imagine that communicating from the prerm which VPNs were stopped so only those can be started in the postinst isn't an easy thing. But I don't see any use to the current behavior so perhaps stop2upgrade should be removed?

Thanks for your help and I appreciate your work maintaining openvpn.

Dave


--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to