Package: release.debian.org Severity: normal Tags: bookworm User: release.debian....@packages.debian.org Usertags: pu X-Debbugs-Cc: freedom...@packages.debian.org Control: affects -1 + src:freedombox
[ Reason ] FreedomBox has a feature to automatically install new versions of freedombox package from backports. This feature is optional but recommended, so most FreedomBox users will have it enabled. This was working as expected for bullseye-backports. However for bookworm-backports, there is a change in the Release file where the Suite and Codename are no longer the same. The configuration produced by FreedomBox is no longer valid due to this change (bug #1043969). [ Impact ] It will lead to confusion for FreedomBox users who are expecting to see newer versions applied automatically. Many of them may not be aware of how to perform the upgrade using the command line. [ Tests ] I manually tested by installing the fixed package on a bookworm system with freedombox. [ Risks ] The code change is simple, so I do not see any risk. [ Checklist ] [X] *all* changes are documented in the d/changelog [X] I reviewed all changes and I approve them [X] attach debdiff against the package in (old)stable [X] the issue is verified as fixed in unstable [ Changes ] 1. Change the code that generates an apt preferences file for pinning freedombox package. Use "n=" instead of "a=" so we refer to the Codename instead of Suite. 2. Make a similar change in the code that generates an apt config file for unattended-upgrades. Use "n=" instead of "a=" in the Origins-Pattern referring to backports. 3. Increment the version number of the FreedomBox Upgrades app. This causes the above changes to be applied.
diff -Nru freedombox-23.6.2/debian/changelog
freedombox-23.6.2+deb12u1/debian/changelog
--- freedombox-23.6.2/debian/changelog 2023-05-01 08:49:06.000000000 -0400
+++ freedombox-23.6.2+deb12u1/debian/changelog 2023-08-13 17:58:38.000000000
-0400
@@ -1,3 +1,10 @@
+freedombox (23.6.2+deb12u1) bookworm; urgency=medium
+
+ * upgrades: Use n= in apt preferences
+ * upgrades: Use n= for unattended-upgrades origin pattern (Closes: #1043969)
+
+ -- James Valleroy <jvalle...@mailbox.org> Sun, 13 Aug 2023 17:58:38 -0400
+
freedombox (23.6.2) unstable; urgency=medium
[ James Valleroy ]
diff -Nru
freedombox-23.6.2/plinth/modules/upgrades/data/etc/apt/apt.conf.d/60unattended-upgrades
freedombox-23.6.2+deb12u1/plinth/modules/upgrades/data/etc/apt/apt.conf.d/60unattended-upgrades
---
freedombox-23.6.2/plinth/modules/upgrades/data/etc/apt/apt.conf.d/60unattended-upgrades
2023-05-01 08:49:06.000000000 -0400
+++
freedombox-23.6.2+deb12u1/plinth/modules/upgrades/data/etc/apt/apt.conf.d/60unattended-upgrades
2023-08-13 17:58:38.000000000 -0400
@@ -12,7 +12,7 @@
// ignored. Only packages that have higher priority set explicitly will get
// upgraded. Only selected FreedomBox packages have high priority set on them.
Unattended-Upgrade::Origins-Pattern {
- "o=Debian Backports,a=${distro_codename}-backports,l=Debian Backports";
+ "o=Debian Backports,n=${distro_codename}-backports,l=Debian Backports";
};
// Automatically reboot *WITHOUT CONFIRMATION* if
diff -Nru freedombox-23.6.2/plinth/modules/upgrades/__init__.py
freedombox-23.6.2+deb12u1/plinth/modules/upgrades/__init__.py
--- freedombox-23.6.2/plinth/modules/upgrades/__init__.py 2023-05-01
08:49:06.000000000 -0400
+++ freedombox-23.6.2+deb12u1/plinth/modules/upgrades/__init__.py
2023-08-13 17:58:38.000000000 -0400
@@ -52,7 +52,7 @@
app_id = 'upgrades'
- _version = 15
+ _version = 16
can_be_disabled = False
diff -Nru freedombox-23.6.2/plinth/modules/upgrades/privileged.py
freedombox-23.6.2+deb12u1/plinth/modules/upgrades/privileged.py
--- freedombox-23.6.2/plinth/modules/upgrades/privileged.py 2023-05-01
08:49:06.000000000 -0400
+++ freedombox-23.6.2+deb12u1/plinth/modules/upgrades/privileged.py
2023-08-13 17:58:38.000000000 -0400
@@ -33,7 +33,7 @@
'''Explanation: This file is managed by FreedomBox, do not edit.
Explanation: Allow carefully selected updates to 'freedombox' from backports.
Package: src:freedombox
-Pin: release a={}-backports
+Pin: release n={}-backports
Pin-Priority: 500
'''
OpenPGP_signature
Description: OpenPGP digital signature
