Control: tags -1 + patch
On Sun, 23 Jul 2023 at 18:06:28 +0100, Simon McVittie wrote:
> From a quick look at the binary package dependencies and source code,
> it looks as though darkradiant is a GTK 3 application already, and the only
> reference to gtkmm seems to be in
> plugins/dm.objectives/util/TwoColumnTextCombo.h, which is not compiled
> when using Debian toolchains, only when using MSVC or Xcode. If that's the
> case, then this build-dependency can probably just be dropped.
That was almost true: the darkradiant packaging was also relying on
libgtkmm-2.4-dev to pull in its dependencies libglib2.0-dev and
libsigc++-2.0-dev, which *are* needed.
Adding B-D on libglib2.0-dev and libsigc++-2.0-dev allows libgtkmm-2.4-dev
to be dropped. Please consider the attached patches, also available at
<https://salsa.debian.org/games-team/darkradiant/-/merge_requests/1>.
(I have successfully built this, but I have not otherwise tested the
resulting binaries.)
smcv
>From e29948a72c14c43eeb2dbe4b964821be9254005f Mon Sep 17 00:00:00 2001
From: Simon McVittie <s...@debian.org>
Date: Sun, 23 Jul 2023 18:19:36 +0100
Subject: [PATCH 1/2] Explicitly depend on libglib2.0-dev, libsigc++-2.0-dev
darkradiant explicitly checks for these, so they should be direct
dependencies. Adding them will allow the gtkmm2.4 dependency to be
dropped.
---
debian/control | 2 ++
1 file changed, 2 insertions(+)
diff --git a/debian/control b/debian/control
index 2b6ab69..dcbad2a 100644
--- a/debian/control
+++ b/debian/control
@@ -17,10 +17,12 @@ Build-Depends: asciidoctor,
libeigen3-dev,
libftgl-dev,
libglew-dev,
+ libglib2.0-dev,
libgtkmm-2.4-dev,
libjpeg-dev,
libopenal-dev,
libpython3-dev,
+ libsigc++-2.0-dev,
libvorbis-dev,
libwxgtk3.2-dev,
libxml2-dev,
--
2.40.1
>From 2380dee34b4474ed9cd0e42c91f7d0943419fc09 Mon Sep 17 00:00:00 2001
From: Simon McVittie <s...@debian.org>
Date: Sun, 23 Jul 2023 18:03:41 +0100
Subject: [PATCH 2/2] Remove unnecessary B-D libgtkmm-2.4-dev
This is only used in plugins/dm.objectives/util/TwoColumnTextCombo.h,
which is not compiled with Debian toolchains (only with MSVC or Xcode).
Closes: #1041791
---
debian/control | 1 -
1 file changed, 1 deletion(-)
diff --git a/debian/control b/debian/control
index dcbad2a..9ef4707 100644
--- a/debian/control
+++ b/debian/control
@@ -18,7 +18,6 @@ Build-Depends: asciidoctor,
libftgl-dev,
libglew-dev,
libglib2.0-dev,
- libgtkmm-2.4-dev,
libjpeg-dev,
libopenal-dev,
libpython3-dev,
--
2.40.1
