Hi! On Fri, Jul 21, 2023 at 1:12 AM Étienne Mollier <emoll...@debian.org> wrote: > > Hi, > > Bo YU, on 2023-07-21: > > On Thu, Jul 20, 2023 at 5:34 PM Étienne Mollier <emoll...@debian.org> wrote: > > > Bo YU, on 2023-07-20: > > > > I will clean up the change for here and upstream. > > > > > > Sounds good, let us know once you pushed your modification. > > > > I have updated it here: > > https://salsa.debian.org/med-team/spades > > > > The only thing this is uncertain about is whether the distribution > > should be UNRELEASE or unstable > > in changelog. In Debian python team, it was `UNRELEASE` if team upload > > from non-DD/DM. So l use it there. > > I'm fine with both convention; having a the changelog entry > stating "unstable" at least makes it clear the last person > having touched intended to have the package ready for upload. > The state can be reverted easily to UNRELEASED if something off > is noted. > > By contrast the tag would be more problematic to remove after > being pushed to the VCS. Personally, I usually run dgit, which > does the tagging for me on upload, so always tag and push after > the actual upload of the package. > > > Could you have a look?:) > > The RC bug is appropriately addressed, well done! > > The only issues I caught were some trailing blank spaces in the > changelog, and the named log entry was a bit redundant since > your change is the only one since last spades upload. I patched > these out along setting the package to ready it for upload; see > what I mean: > > --- a/debian/changelog > +++ b/debian/changelog > @@ -1,8 +1,6 @@ > -spades (3.15.5+dfsg-3) UNRELEASED; urgency=medium > - > +spades (3.15.5+dfsg-3) unstable; urgency=medium > + > * Team upload. > - > - [Bo YU] > * Add fix-gcc13.patch to fix gcc-13 build issues. (Closes: > #1037863) > > -- Bo YU <tsu.y...@gmail.com> Thu, 20 Jul 2023 21:38:50 +0800 > > > Otherwise your bug fix is uploaded. > Thank you for your contribution!
Thanks for your upload and fixed it for me. I will keep it mind. BR, Bo > > Have a nice day, :) > -- > .''`. Étienne Mollier <emoll...@debian.org> > : :' : gpg: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da > `. `' sent from /dev/pts/2, please excuse my verbosity > `- on air: Need - Entheogen
