Package: cil Version: 0.07.00-12 Severity: normal Tags: upstream patch Dear Maintainer,
When querying tasks which are under my responsibility, I notice
on filtering with --is-mine that I have one warning per instance
of task which is not mine:
$ cil summary
===============================================================================
3f8260ce New not mine ter
51954acd New mine bis
5e3df180 New mine
72f2511e New not mine bis
93f983e6 New not mine
===============================================================================
$ cil summary --is-mine
Use of uninitialized value in string eq at
/usr/share/perl5/CIL/Utils.pm line 464.
Use of uninitialized value in string eq at
/usr/share/perl5/CIL/Utils.pm line 464.
Use of uninitialized value in string eq at
/usr/share/perl5/CIL/Utils.pm line 464.
===============================================================================
51954acd New mine bis
5e3df180 New mine
===============================================================================
This is not a blocker per se, just a mere annoyance. I tracked
this warning down an $email_address which may or may not be
defined depending on whether the field has been set. I tried a
couple of changes based on `if defined $var`, but none of those
approaches led to a working situation. If I apply the following
patch, in which I ensure the $email_address is always set, even
if this is the empty string, then I can resolve the noise, and I
have not seen any adverse effect so far:
-------8<--------------8<--------------8<--------------8<-------
--- cil-0.07.00.orig/lib/CIL/Utils.pm
+++ cil-0.07.00/lib/CIL/Utils.pm
@@ -565,7 +565,7 @@
sub extract_email_address {
my ($class, $text) = @_;
- my $email_address;
+ my $email_address = "";
my $num_found = find_emails(
$text,
sub {
-------8<--------------8<--------------8<--------------8<-------
Same command as before, but this time with the patch applied:
$ cil summary --is-mine
===============================================================================
51954acd New mine bis
5e3df180 New mine
===============================================================================
Thanks for considering this change if you deem it useful! I was
hoping to feed the fix directly upstream, but it seems their
repository[1] is archived for a while.
[1]: https://github.com/chilts/cil
Have a nice day, :)
Étienne.
-- System Information:
Debian Release: trixie/sid
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386
Kernel: Linux 6.3.0-2-amd64 (SMP w/12 CPU threads; PREEMPT)
Locale: LANG=C.UTF-8, LC_CTYPE=C.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled
Versions of packages cil depends on:
ii dpkg 1.21.22
ii libclass-accessor-perl 0.51-2
ii libdatetime-perl 2:1.59-1
ii libemail-date-perl 1.104-4
ii libemail-find-perl 0.10-dfsg-4
ii libemail-simple-perl 2.218-1
ii libfile-homedir-perl 1.006-2
ii libfile-slurp-perl 9999.32-2
ii libfile-touch-perl 0.12-2
ii perl [libdigest-perl] 5.36.0-7
cil recommends no packages.
cil suggests no packages.
-- no debconf information
--
.''`. Étienne Mollier <emoll...@debian.org>
: :' : gpg: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da
`. `' sent from /dev/pts/1, please excuse my verbosity
`- on air: Transatlantic - All Of The Above
signature.asc
Description: PGP signature
