Andree Leidenfrost said on Sun, May 14, 2006 at 09:21:18PM +1000: > Sorry for the delay, I was flat out with CeBIT Australia.
And I was way too busy this week. > The attached patch is what is in mondo-2.07-2 for Debian. It does not > include your suggestions below. I decided to release something (for > Debian) to keep some momentum and because I am not sure how much time > I'll have in the near future. I hope that is ok. That's GREAT ! > Hm, I think the memmove command is watertight. But if you want to > standardise on using asprintf pretty much exclusively that's ok with me, > too. It's just a bit clumsier (but probably less error-prone, so fair > enough). Ok, I changed the memmove to asprintf. Please check if it's still correct. > > I wonder if I'll not commit a first set of asprintf changes from trunk > > to stable, now that we go to 2.2.0. WDYT ? > > I think this would be really, really. I am all for 'release early, > release often' which in this case would mean to phase the asprintf > things in - the code will become safer with every asprintf that we put > in. So, go for it! Ok. So what I do now, is that stable is really what the title suggests: stable ;-) No new big modif will go in it, only bug fixes of 2.0.x. I've reverted all my recent modificatios in it and put them in trunk only. trunk will become the next 2.2.x serie. So it will include all aspintf modifs I've made since now. Beware that it may not compile. And if it compiles, it will NOT work now. I need to address the structures before being able to have something. > > Maybe we should write our own mr_strtok function which will do it > > correctly ? > > That may be the best thing to do. Ok I integrated your patch, and replace calls to strtok by calls to mr_strtok. Could you chack it still works for you ? (I didn't know the strspn functions you used, nice catch :-) > I'll see whether I can work on an updated patch incorporating your > latest suggestions, but thought I send this through first (including the > current patch). No worry I did it, I hope correctly. At least it will be in 2.0.8. I may integrate a last correction for x86_64 for mindi, and work on finishing the multi-distro env. I'll ping you for the Debian script integration. Or can I use the one yo uproduce and just put them in the tree ? I'm working on gentoo currently and hope to have something working next week for that. As for debian, it should be quicker with your content. Greetings, Bruno. -- Linux Profession Lead EMEA / Open Source Evangelist \ HP C&I EMEA IET http://www.mondorescue.org / HP/Intel Solution Center \ http://hpintelco.net Des infos sur Linux? http://www.HyPer-Linux.org http://www.hp.com/linux La musique ancienne? http://www.musique-ancienne.org http://www.medieval.org
pgpDg2cMTk1uQ.pgp
Description: PGP signature
