Package: release.debian.org
Severity: normal
Tags: bookworm
User: release.debian....@packages.debian.org
Usertags: pu
X-Debbugs-Cc: ma...@packages.debian.org
Control: affects -1 + src:marco
[ Reason ]
In cases where users run KDE apps such as kwrite or kcalc in a MATE
desktop session as superuser it happens that window titles in
mate-panel/tasklist (libwnck) show only " (as superuser)". When trying
nedit, nedit-ng, and gedit, etc. those don't seem to trigger this.
[ Impact ]
UI/UX improvement for MATE users using KDE apps.
[ Tests ]
Code review. Local test on bookworm system (launch kwrite as root in
MATE desktop session). Issue reported in #1040752 could be reproduced.
Updating to marco 1.26.1-3+deb12u1 resolves the issue.
[ Risks ]
Minimal. MATE's window manager might show regressions in handling window
titles.
[ Checklist ]
[x] *all* changes are documented in the d/changelog
[x] I reviewed all changes and I approve them
[x] attach debdiff against the package in (old)stable
[x] the issue is verified as fixed in unstable
[ Changes ]
+ * debian/patches:
+ + Add 0004_show-correct-window-title-when-owned-by-superuser.patch. Fix
+ window titles sometimes shown incorrectly when owned as root. This
+ affects mostly KDE apps if they are run on MATE. (Closes: #1040752).
[ Other info ]
None.
diff -Nru marco-1.26.1/debian/changelog marco-1.26.1/debian/changelog
--- marco-1.26.1/debian/changelog 2023-04-26 07:46:12.000000000 +0200
+++ marco-1.26.1/debian/changelog 2023-07-10 06:47:02.000000000 +0200
@@ -1,3 +1,12 @@
+marco (1.26.1-3+deb12u1) bookworm; urgency=medium
+
+ * debian/patches:
+ + Add 0004_show-correct-window-title-when-owned-by-superuser.patch. Fix
+ window titles sometimes shown incorrectly when owned as root. This
+ affects mostly KDE apps if they are run on MATE. (Closes: #1040752).
+
+ -- Mike Gabriel <mike.gabr...@das-netzwerkteam.de> Mon, 10 Jul 2023 06:47:02
+0200
+
marco (1.26.1-3) unstable; urgency=medium
* Revert "debian/control: Drop B-D: libxpresent-dev." introduced with
diff -Nru
marco-1.26.1/debian/patches/0004_show-correct-window-title-when-owned-by-superuser.patch
marco-1.26.1/debian/patches/0004_show-correct-window-title-when-owned-by-superuser.patch
---
marco-1.26.1/debian/patches/0004_show-correct-window-title-when-owned-by-superuser.patch
1970-01-01 01:00:00.000000000 +0100
+++
marco-1.26.1/debian/patches/0004_show-correct-window-title-when-owned-by-superuser.patch
2023-07-10 06:44:37.000000000 +0200
@@ -0,0 +1,22 @@
+<S-Del>From 730ed9dc454e97f569df8a92ac065a1afcc05baa Mon Sep 17 00:00:00 2001
+From: insaner <insa...@users.noreply.github.com>
+Date: Wed, 25 Jan 2023 21:35:07 -0500
+Subject: [PATCH] Show correct window title when owned by superuser. Issue #749
+
+---
+ src/core/window-props.c | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/src/core/window-props.c b/src/core/window-props.c
+index 71c9d203c..3a01f6f6f 100644
+--- a/src/core/window-props.c
++++ b/src/core/window-props.c
+@@ -489,7 +489,7 @@ set_title_text (MetaWindow *window,
+
+ g_free (*target);
+
+- if (!title)
++ if (!title || g_utf8_strlen (title, 2) < 1)
+ *target = g_strdup ("");
+ else if (g_utf8_strlen (title, MAX_TITLE_LENGTH + 1) > MAX_TITLE_LENGTH)
+ {
diff -Nru marco-1.26.1/debian/patches/series marco-1.26.1/debian/patches/series
--- marco-1.26.1/debian/patches/series 2023-04-25 15:34:49.000000000 +0200
+++ marco-1.26.1/debian/patches/series 2023-07-10 06:45:35.000000000 +0200
@@ -1,6 +1,6 @@
-
0000_shadows.patch
1001_marco-Add-cmdline-option-no-keybindings-for-disablin.patch
0001_test-retval-from-XResQueryClientIds.patch
0002_test-xres-1.2-is-present.patch
0003_test-if-XResQueryClientIds-is-available.patch
+0004_show-correct-window-title-when-owned-by-superuser.patch
