On 20230622@08:08, Rafael Laboissière wrote: > * Michele Martone <michelemart...@users.sourceforge.net> [2023-06-21 23:43]: > > > On 20230618@22:27, Rafael Laboissière wrote: > > > * Simon McVittie <s...@debian.org> [2023-06-18 17:10]: > > > > > > > On Sat, 17 Jun 2023 at 21:11:25 +0200, Rafael Laboissière wrote: > > > > > Thanks for this bug report. I forwarded it upstream and I am also > > > > > sending > > > > > this message with Cc to the upstream author. > > > > > > > > Thanks. In the meantime, please could you check whether fim > > > > works as intended with libsdl1.2-compat-shim, which is meant to > > > > be a drop-in replacement? I'm trying to track whether there are > > > > any blockers to replacing "classic" SDL 1.2. > > > > > > The package builds fine against libsdl1.2-compat-dev on my sid amd64 > > > system. All tests also passed, but I am not sure this would be > > > enough. I would rather let the upstream author have the final word, > > > but if you think I should upload a new version of the package with > > > that build-dependency, please tell me. > > > > Dear Rafael, dear Simon, > > > > If using the compatibility layer and: > > > > * `make tests` passes > > It is not straightforward for me to do this test, because I build the > package on a remote system, and SDL does not play well with xvfb-run. > > On the other hand the unit tests that are exercised in file > debian/test/run-tests succeeded. Essentially, this corresponds to: > > make -C src/testdir > > > * you can start `fim -o sdl $FILE` and move around by pressing n, p, > > then enlarging/shrinking with + and -, using the arrows to scroll, and > > : to start the console, and after : typing 'quit' and it quits, plus > > the window is resizable > > The window starts with the image flushed to the bottom right, and not > centered as with the previous version. > > Keys n, p, + and - work correctly. The arrow keys work also, but there is > some flickering that I did not observe previously. > > Typing ":quit" works, but there is no echo of the console at the bottom of > the window. > > So, it mainly works but the behavior with the compatibility version of the > SDL library is not exactly the same as with the old version of SDL. > > Best, > > Rafael
Dear Rafael,
Thank you for testing out this combination.
As you describe it, it seems perfectly acceptable to me.
If I understand correctly, you're using here a version of FIM
from one year ago or more.
After that, I introduced centering by inserting line
setenv("SDL_VIDEO_CENTERED","1",0);
in SDLDevice::initialize(), on the line just before calling
SDL_Init().
If that can make sense to you, you can introduce that line as
a patch. I'll need some calm time in order to port to SDL2 --
but I understand it's something I shall do soon.
ciao,
Michele
signature.asc
Description: PGP signature
