* Matt Swift <[EMAIL PROTECTED]> [2006-05-19 12:11]:
> The current test looks for the file in os.environ.get("PATH", "").
> 
> The test should look for the file in sys.path, which is different.
> This is the load path for Python modules.

Right, but I'm not looking for the Python module.  I'm looking for the
Unix executable that is your ripper or encoder.

>     M> What's wrong with the following patch:
> 
> 1) It's wrong to  remove the "plugin_" prefix.  The correct
>    full path for a plugin is "~/.jack_plugins/jack_plugin_lame.py".  I

Yes, but I'm not looking for this... I'm looking for the "lame"
executable.  As far as I know, your encoder is specified as
"plugin_lame" (i.e. jack -E plugin_lame or something similar in the
config file).  I then remove the plugin_ prefix and check for the
rest, i.e lame.

>    don't know if the "plugin_" prefix is required, but removing it
>    here is going cause the test to fail because it's looking for a
>    file that does not exist: "lame.py".

I'm not looking for the Python module, but the Unix executable.

So, having said this, does my patch work and get rid of the original
error?

If not, can you send me your ~/.jack3rc file.
-- 
Martin Michlmayr
http://www.cyrius.com/


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]

Reply via email to