Package: rasdaemon
Version: 0.6.8-1.1
Severity: minor
Tags: patch

Dear Maintainer,

rasdaemon(8) says
  CONFIG FILE
         The rasdaemon program supports a config file to set rasdaemon systemd 
service environment variables. By default the config file is read from 
/etc/sysconfig/ras‐
         daemon.

         The general format is environmentname=value.
the weirdness of that aside, /etc/sysconfig/rasdaemon doesn't exist.
/etc/default/rasdaemon does, however, and says:
  # Page Isolation
  # Note: Run-time configuration is unsupported, service restart needed.
  # Note: this file should be installed at /etc/sysconfig/rasdaemon
  
  # Specify the threshold of isolating buggy pages.
  #
  # Format:
  #   [0-9]+[unit]
  # Notice: please make sure match this format, rasdaemon will use default 
value for exception input cases.
  #
  # Supported units:
  # PAGE_CE_REFRESH_CYCLE: D|d (day), H|h (hour), M|m (min), default is in hour
  # PAGE_CE_THRESHOLD: K|k (x1000), M|m (x1000k), default is none
  #
  # The two configs will only take no effect when PAGE_CE_ACTION is "off".
  PAGE_CE_REFRESH_CYCLE="24h"
  PAGE_CE_THRESHOLD="50"
  
  # Specify the internal action in rasdaemon to exceeding a page error 
threshold.
  #
  # off      no action
  # account  only account errors
  # soft     try to soft-offline page without killing any processes
  #          This requires an uptodate kernel. Might not be successfull.
  # hard     try to hard-offline page by killing processes
  #          Requires an uptodate kernel. Might not be successfull.
  # soft-then-hard   First try to soft offline, then try hard offlining.
  # Note: default offline choice is "soft".
  PAGE_CE_ACTION="soft"

Again, it shouldn't on Debian because the service says
  $ systemctl cat rasdaemon.service
  # /lib/systemd/system/rasdaemon.service
  [Unit]
  Description=RAS daemon to log the RAS events
  # only needed when not running in foreground (--foreground | -f)
  #After=syslog.target
  
  [Service]
  EnvironmentFile=/etc/default/rasdaemon
  ExecStart=/usr/sbin/rasdaemon -f -r
  ExecStartPost=/usr/sbin/rasdaemon --enable
  ExecStop=/usr/sbin/rasdaemon --disable
  Restart=on-abort
  
  [Install]
  WantedBy=multi-user.target

To that end, I'm attaching three patches (also at Salsa as
 https://salsa.debian.org/tai271828/rasdaemon-sandbox-01/-/merge_requests/1):
  * fixing /etc/default/rasdaemon
  * fixing rasdaemon(8) by replacing that whole section with
      .SH FILES
      .B /etc/default/rasdaemon
  * fixing rasdaemon(8) and ras-mc-ctl(8) by removing the empty line
    from before .TH, which removes the empty line before the heading

-- System Information:
Debian Release: 12.0
  APT prefers stable-security
  APT policy: (500, 'stable-security'), (500, 'stable-debug'), (500, 'stable')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 6.1.0-9-amd64 (SMP w/24 CPU threads; PREEMPT)
Kernel taint flags: TAINT_PROPRIETARY_MODULE, TAINT_FIRMWARE_WORKAROUND, 
TAINT_OOT_MODULE, TAINT_UNSIGNED_MODULE
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8), 
LANGUAGE=en_GB:en
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages rasdaemon depends on:
ii  init-system-helpers  1.65.2
ii  libc6                2.36-9
ii  libdbd-sqlite3-perl  1.72-1
ii  libsqlite3-0         3.40.1-2
ii  perl                 5.36.0-7
ii  sqlite3              3.40.1-2

rasdaemon recommends no packages.

rasdaemon suggests no packages.

-- no debconf information

Attachment: signature.asc
Description: PGP signature

Reply via email to