Package: release.debian.org Severity: normal User: release.debian....@packages.debian.org Usertags: unblock
Please unblock package debian-edu-fai [ Reason ] In the context of #1035654, a few source packages (including this one) still fail to purge remove without adduser installed. [ Impact ] We want to avoid the situation where a user removes the package, then upgrades to apt that doesn't depend on adduser, then removes adduser and then attempts to purge this package. [ Tests ] See the script Josch posted in #1035654. [ Risks ] Low risk due to trivial changes (see end of this mail) and because of low popcon number (1 vote, so far). In addition to the adduser changes, the diff to testing also includes a simple directory-exists test before writing to it. [ Checklist ] [ ] all changes are documented in the d/changelog [ ] I reviewed all changes and I approve them [ ] attach debdiff against the package in testing [ Other info ] The debian-edu-fai package has not yet been tested with FAI 6.0. I expect to work on this in the next few weeks. The required fixes will be provided via a bookworm-pu upload for the 12.1 point release. unblock debian-edu-fai/2023.05.16.1 + * bin/debian-edu-faiinstall: Make sure FAI_CONFIGDIR_REAL is set before it + is accessed. + * debian/postrm: Ignore failures during execution of deluser/delgroup. + (Closes: #1035292).
diff -Nru debian-edu-fai-2022.04.14.1/bin/debian-edu-faiinstall debian-edu-fai-2023.05.16.1/bin/debian-edu-faiinstall --- debian-edu-fai-2022.04.14.1/bin/debian-edu-faiinstall 2022-09-16 20:38:21.000000000 +0200 +++ debian-edu-fai-2023.05.16.1/bin/debian-edu-faiinstall 2023-05-16 22:59:12.000000000 +0200 @@ -184,6 +184,7 @@ [ "$FAI_DEBOOTSTRAP_OPTS" ] || FAI_DEBOOTSTRAP_OPTS="--arch=${arch}" [ "$FAI_CONFIGDIR" ] || FAI_CONFIGDIR="/srv/fai/config" + FAI_CONFIGDIR_REAL="${FAI_CONFIGDIR}" # if FAI_CONFIGDIR is a symlink, we need to find the real location... if [ -h ${FAI_CONFIGDIR} ]; then FAI_CONFIGDIR_REAL="$(readlink ${FAI_CONFIGDIR})" diff -Nru debian-edu-fai-2022.04.14.1/ChangeLog debian-edu-fai-2023.05.16.1/ChangeLog --- debian-edu-fai-2022.04.14.1/ChangeLog 2022-09-16 20:38:21.000000000 +0200 +++ debian-edu-fai-2023.05.16.1/ChangeLog 2023-05-16 23:00:47.000000000 +0200 @@ -1,6 +1,21 @@ +2023-05-16 Mike Gabriel + + * release 2023.05.16.1 (HEAD -> master, tag: 2023.05.16.1) + * debian/postrm: Ignore failures during execution of + deluser/delgroup: (Closes: #1035292). (bee8be2) + +2022-09-17 Mike Gabriel + + * bin/debian-edu-faiinstall: Make sure FAI_CONFIGDIR_REAL is set + before it is accessed. (9d8fba3) + 2022-09-16 Mike Gabriel - * release 2022.04.14.1 (HEAD -> master, tag: 2022.04.14.1) + * release debian/2022.04.14.1 (9b87327) (tag: debian/2022.04.14.1) + * debian/control: Add Rules-Requires-Root: field and set it to 'no'. + (6593c3e) + * debian/control: Bump Standards-Version: to 4.6.1. No changes + needed. (3c7a20e) 2022-04-14 Mike Gabriel diff -Nru debian-edu-fai-2022.04.14.1/debian/changelog debian-edu-fai-2023.05.16.1/debian/changelog --- debian-edu-fai-2022.04.14.1/debian/changelog 2022-09-16 20:38:21.000000000 +0200 +++ debian-edu-fai-2023.05.16.1/debian/changelog 2023-05-16 23:00:47.000000000 +0200 @@ -1,3 +1,12 @@ +debian-edu-fai (2023.05.16.1) unstable; urgency=medium + + * bin/debian-edu-faiinstall: Make sure FAI_CONFIGDIR_REAL is set before it + is accessed. + * debian/postrm: Ignore failures during execution of deluser/delgroup. + (Closes: #1035292). + + -- Mike Gabriel <sunwea...@debian.org> Tue, 16 May 2023 23:00:47 +0200 + debian-edu-fai (2022.04.14.1) unstable; urgency=medium * fai/config/scripts/GRUB_EFI/10-setup: diff -Nru debian-edu-fai-2022.04.14.1/debian/postrm debian-edu-fai-2023.05.16.1/debian/postrm --- debian-edu-fai-2022.04.14.1/debian/postrm 2022-09-16 20:38:21.000000000 +0200 +++ debian-edu-fai-2023.05.16.1/debian/postrm 2023-05-16 23:00:14.000000000 +0200 @@ -18,7 +18,7 @@ case "$1" in purge) - getent passwd fai 1>/dev/null && deluser fai + getent passwd fai 1>/dev/null && deluser fai || true rm -Rf /var/log/fai/client-logs/ ;;