On 2023-05-21 19:36, Petter Reinholdtsen wrote:
> [Aurelien Jarno]
> > Support for riscv64 has been added to bpfcc in upstream version 0.25.
> > Enabling it on the debian packaging side is just about adding the
> > architecture to debian/control. I have attached the patch I tested,
> > would it be possible to include it in the next upload?
>
> In #1030657 a discussion to remove the arch limits is present, and this
> has since been done. But as can be seen from
> <URL: https://buildd.debian.org/status/package.php?p=bpfcc&suite=experimental
> >,
> more is needed for riscv64, which fail like this:
>
> make[1]: Leaving directory '/<<PKGBUILDDIR>>'
> dh_install -a -O--buildsystem=cmake
> dh_install: warning: Cannot find (any matches for) "usr/bin/bcc-lua" (tried
> in ., debian/tmp)
>
> dh_install: warning: bpfcc-lua missing files: usr/bin/bcc-lua
> dh_install: error: missing files, aborting
> make: *** [debian/rules:24: binary-arch] Error 25
>
> Perhaps you can figure out what is missing there?
It seems the change has been too wide, bpfcc lua support seems only
available on amd64, that's why it fails everywhere except amd64. The
following patch fixes the build on riscv64 and likely a few other
architectures:
diff -Nru bpfcc-0.26.0+ds/debian/control bpfcc-0.26.0+ds/debian/control
--- bpfcc-0.26.0+ds/debian/control 2023-02-16 16:39:53.000000000 +0100
+++ bpfcc-0.26.0+ds/debian/control 2023-05-21 20:06:51.000000000 +0200
@@ -132,7 +132,7 @@
.
Package: bpfcc-lua
-Architecture: linux-any
+Architecture: amd64
Depends: libbpfcc (>= ${binary:Version}),
${misc:Depends},
${shlibs:Depends}
However there is more work to do for some other architectures, to ensure
that the libbpf_tool_skip_arch variable in debian/rules matches the
architectures in debian/control.
--
Aurelien Jarno GPG: 4096R/1DDD8C9B
aurel...@aurel32.net http://aurel32.net
