On Mon, May 15, 2023 at 7:36 PM Martin-Éric Racine <martin-eric.rac...@iki.fi> wrote: > > On Mon, May 15, 2023 at 2:32 PM Shengjing Zhu <z...@debian.org> wrote: > > > > On Mon, May 15, 2023 at 7:23 PM Martin-Éric Racine > > <martin-eric.rac...@iki.fi> wrote: > > > > > > On Mon, May 15, 2023 at 2:13 PM Shengjing Zhu <z...@debian.org> wrote: > > > > > > > > On Mon, May 15, 2023 at 7:09 PM Martin-Éric Racine > > > > <martin-eric.rac...@iki.fi> wrote: > > > > > > > > > > On Mon, May 15, 2023 at 1:58 PM Shengjing Zhu <z...@debian.org> wrote: > > > > > > > > > > > > On Mon, May 15, 2023 at 6:53 PM Martin-Éric Racine > > > > > > <martin-eric.rac...@iki.fi> wrote: > > > > > > > > > > > > > > On Mon, May 15, 2023 at 1:36 PM Shengjing Zhu <z...@debian.org> > > > > > > > wrote: > > > > > > > > Package: dhcpcd-base > > > > > > > > Version: 9.4.1-21 > > > > > > > > Severity: important > > > > > > > > X-Debbugs-Cc: z...@debian.org > > > > > > > > > > > > > > > > For bookworm ntpsec has replaced the old ntp. > > > > > > > > See https://bugs.debian.org/1003966 > > > > > > > > > > > > > > > > ntpsec (1.2.1+dfsg1-5) experimental; urgency=medium > > > > > > > > . > > > > > > > > * Add ntpd.service alias > > > > > > > > * Add ntp transitional packages (Closes: 1003966) > > > > > > > > > > > > > > > > Now the hook is wrong to assume the existence of /etc/ntp.conf > > > > > > > > and > > > > > > > > /run/ntp.conf.dhcp > > > > > > > > > > > > > > Can you file a bug report upstream? As of 10.0.1-1 (pending > > > > > > > upload), > > > > > > > I have deprecated Debian's NTP hooks and use upstream's NTP hooks > > > > > > > instead. Any missing support for alternative NTP daemons would be > > > > > > > best > > > > > > > filed there. > > > > > > > > > > > > > > > > > > > It's filed for version 9.4.1-21, which is going to be included in > > > > > > Debian Bookworm. However ntpd has been replaced by ntpsec in Debian > > > > > > Bookworm. So the hook is wrong now. And the hook is a Debian > > > > > > specific > > > > > > patch. > > > > > > If you don't want to continue supporting ntpsec, I would suggest > > > > > > removing this non-working hook for Bookworm (and its autopkgtest). > > > > > > > > > > I'm not gonna introduce any change to the package for Bookworm this > > > > > late into the freeze. > > > > > > > > > > > > > However this is a real bug for Bookworm. Shipping non-working parts is > > > > worse than non-support. > > > > ntpsec taking over ntpd already happens for Bookworm. > > > > > > If you want to have ntpsec support in Bookworm, please submit a patch > > > to add ntpsec support to the current hooks and ask the Bookworm > > > release manager for an exemption to the freeze. > > > > TBH I really don't use ntpsec. I just looked through this package and > > its autopkgtest. > > > > Why do you think patching ntpsec is the right thing here? > > Please read again.
I'm pretty sure I have read it carefully. Support for various ntp implementations is located in dhcpcd's hook dir. It's not any ntp implementation's responsibility to integrate with dhcpcd. > > > There is no old ntpd in Bookworm anymore, it's already been removed. > > You include a non-working patch in dhcpcd and an always failing > > autopkgtest. What's the benefit for the quality? > > I'm not interested in getting into a debate about this. I'm not sure why you are so resistant about this. Are you worried about the extra works? I certainly can work this for you and file unblock request. But since the strong maintainship in Debian, it still needs you to agree on. -- Shengjing Zhu
