Source: lcov
Severity: normal
Tags: patch
User: reproducible-bui...@lists.alioth.debian.org
Usertags: timestamps timezone
X-Debbugs-Cc: reproducible-b...@lists.alioth.debian.org

The build timestamp is embedded in various /usr/bin/* files is timezone
dependent:

  
https://tests.reproducible-builds.org/debian/rb-pkg/bookworm/amd64/diffoscope-results/lcov.html

  lcov_1.16-1_all.deb

  
-rwxr-xr-x···0·root·········(0)·root·········(0)·····4568·2022-06-06·08:19:45.000000·./usr/bin/gendesc
  vs.
  
-rwxr-xr-x···0·root·········(0)·root·········(0)·····4568·2022-06-05·18:19:45.000000·./usr/bin/gendesc


The attached patch fixes this by removing a call to touch from the
updateversion.pl script.


According to my local tests, with this patch applied lcov should build
reproducibly on tests.reproducible-builds.org!


Thanks for maintaining lcov!


live well,
  vagrant
From f5e0643c16b6980a32602dbef893f5017418d936 Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagr...@reproducible-builds.org>
Date: Tue, 2 May 2023 10:09:42 -0700
Subject: [PATCH] bin/updateversion.pl: Avoid setting the timestamp built
 files.

The reference file may have a timezone-dependent timestamp.

https://reproducible-builds.org/docs/timezones/
---
 bin/updateversion.pl | 1 -
 1 file changed, 1 deletion(-)

diff --git a/bin/updateversion.pl b/bin/updateversion.pl
index 04b038d..29427b9 100755
--- a/bin/updateversion.pl
+++ b/bin/updateversion.pl
@@ -141,7 +141,6 @@ sub update_bin_tool($)
 	close(IN);
 	chmod(oct($date[2]), "$filename.new");
 	system("mv", "-f", "$filename.new", "$filename");
-	system("touch", "$filename", "-t", $date[1]);
 }
 
 sub update_txt_file($)
-- 
2.39.2

Attachment: signature.asc
Description: PGP signature

Reply via email to