Control: tags -1 + patch
On 2023-04-20 20:10 +0200, Sven Joachim wrote:
> Source: fbterm
> Version: 1.7-5
> Tags: ftbfs
>
> If ncurses is configured with "--disable-root-env", fbterm FTBFS. The
> reason is that with that option ncurses programs ignore the TERMINFO
> variable when run as root, or even under fakeroot. From my build log:
>
> ,----
> | TERMINFO=/tmp/fbterm-1.7/debian/fbterm/usr/share/terminfo tic fbterm
> | "fbterm", line 2, terminal 'fbterm': /etc/terminfo/f: permission denied
> | make[3]: *** [Makefile:424: install-data-local] Error 1
> | make[3]: Leaving directory '/tmp/fbterm-1.7/terminfo'
> | make[2]: *** [Makefile:317: install-am] Error 2
> | make[2]: Leaving directory '/tmp/fbterm-1.7/terminfo'
> | make[1]: *** [Makefile:378: install-recursive] Error 1
> | make[1]: Leaving directory '/tmp/fbterm-1.7'
> | dh_auto_install: error: make -j2 install
> DESTDIR=/tmp/fbterm-1.7/debian/fbterm AM_UPDATE_INFO_DIR=no returned exit
> code 2
> | make: *** [debian/rules:4: binary] Error 25
> `----
The attached patch takes care of that by using tic's -o option instead
of the TERMINFO variable. I find it rather strange that you are
patching both Makefile.am and Makefile.in, as the latter should be
regenerated from the former, but whatever.
BTW, my suggestion to let ncurses-term take over the fbterm terminfo
entry (see #897959) still holds.
Cheers,
Sven
From 055ae93fac996d66e0be3891eb134847f5e4241f Mon Sep 17 00:00:00 2001
From: Sven Joachim <svenj...@gmx.de>
Date: Thu, 20 Apr 2023 20:23:14 +0200
Subject: [PATCH] Use tic's -o option to install the fbterm terminfo file
Rather than relying on the TERMINFO variable, which does not work
under fakeroot if ncurses is configured with "--disable-root-env".
Closes: #1034644
---
debian/patches/01_add_terminfo_path | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/debian/patches/01_add_terminfo_path b/debian/patches/01_add_terminfo_path
index 8f186f8..65f31bf 100644
--- a/debian/patches/01_add_terminfo_path
+++ b/debian/patches/01_add_terminfo_path
@@ -1,6 +1,6 @@
Description: Add TERMINFO path to terminfo/Makefile.*
Author: Nobuhiro Iwamatsu <iwama...@debian.org>
-Last-Update: 2020-04-20
+Last-Update: 2023-04-20
diff --git a/terminfo/Makefile.am b/terminfo/Makefile.am
index b023297..2c5ba34 100644
@@ -11,7 +11,7 @@ index b023297..2c5ba34 100644
install-data-local:
- tic fbterm
-+ TERMINFO=$(DESTDIR)/usr/share/terminfo tic fbterm
++ tic -o $(DESTDIR)/usr/share/terminfo fbterm
diff --git a/terminfo/Makefile.in b/terminfo/Makefile.in
index 92cfbd9..ae09eb7 100644
--- a/terminfo/Makefile.in
@@ -21,7 +21,7 @@ index 92cfbd9..ae09eb7 100644
install-data-local:
- tic fbterm
-+ TERMINFO=$(DESTDIR)/usr/share/terminfo tic fbterm
++ tic -o $(DESTDIR)/usr/share/terminfo fbterm
# Tell versions [3.59,3.63) of GNU make to not export all variables.
# Otherwise a system limit (for SysV at least) may be exceeded.
--
2.40.0
