Hi,

Sorry for taking so long to respond (the moreinfo tag was still attached to the bug, so it didn't show up in my regular bts view, so please remove it when you reply).

On 16-03-2023 11:40, Christian Kastner wrote:
Overall, the diff is a bit long (and has some irrelevant stuff), so
I'm hesitant to offer t-p-u now (to avoid waiting for
llvm-toolchain-15).

Understood. Yeah, the diff is long, unfortunately, as the packaging
fixes accumulated over time.

That's why (especially around the freeze) we expect maintainers to keep track of migration and ensure they happen. You got stuck behind llvm-toolchain-15, but that's very unlikely to be fixed before the release.

Is this something that you could consider at a later point in time, if I
also break down the diff into more reviewable fragments (dependencies,
build, metadata, ...)? Because I do think that most changes are just
fixes of one sort or another - no features added.

I checked the diff again and I was about to propose to upload it to tpu, but I saw the following:

diff -Nru rocm-hipamd-5.2.3/debian/rules rocm-hipamd-5.2.3/debian/rules
--- rocm-hipamd-5.2.3/debian/rules      2022-10-20 19:20:33.000000000 +0000
+++ rocm-hipamd-5.2.3/debian/rules      2023-03-10 22:38:51.000000000 +0000

[...]
+               -DHIP_PLATFORM=amd

Is that correct for the arm64 builds?

Paul

Attachment: OpenPGP_signature
Description: OpenPGP digital signature

Reply via email to