On 2023-03-19 17:22:21 +0100, László Böszörményi wrote:
> Package: release.debian.org
> Severity: normal
> User: release.debian....@packages.debian.org
> Usertags: unblock
> X-Debbugs-Cc: Cyril Brulebois <k...@debian.org>
> Control: affects -1 + src:fuse3
> 
> Hi RMs,
> 
> [ Reason ]
> The self-testing of fuse3 only works on little-endian machines. I've
> already disabled it on big-endian release architectures. Missed hppa
> which is not added to the list.
> Compiling examples didn't work due to outdated Makefile and using an
> outdated header name in one of the files.
> 
> [ Impact ]
> With the changes fuse3 is compiled on hppa now. As the installer needs
> its udeb it can be created on that architecture as well from now on.
> One of the example files was patched to use the current header file
> name and now compiles with all of the other example files.

hppa is not a release architecture, so that wouldn't count as a
targetted fix. But since it comes with a documentation fix, I'll unblock
it.

Cheers

> 
> [ Tests ]
> I've tested the examples compilation and those are OK now. Compilation
> on hppa is now working as can be seen in the buildd logs [1].
> 
> [ Risks ]
> None of the changes affect the working of the package itself.
> As fuse3 has an udeb I put kibi to the loop if extra ACK is needed.
> 
> [ Checklist ]
>   [X] all changes are documented in the d/changelog
>   [X] I reviewed all changes and I approve them
>   [X] attach debdiff against the package in testing
> 
> unblock fuse3/3.14.0-3
> 
> Thanks for considering,
> Laszlo/GCS
> [1] https://buildd.debian.org/status/logs.php?pkg=fuse3&arch=hppa

> diff -Nru fuse3-3.14.0/debian/changelog fuse3-3.14.0/debian/changelog
> --- fuse3-3.14.0/debian/changelog     2023-02-18 07:22:30.000000000 +0100
> +++ fuse3-3.14.0/debian/changelog     2023-03-17 20:51:05.000000000 +0100
> @@ -1,3 +1,15 @@
> +fuse3 (3.14.0-3) unstable; urgency=medium
> +
> +  [ Helge Deller <del...@gmx.de> ]
> +  * Add the big-endian hppa platform to the disabled self-testing list
> +    (closes: #1032187).
> +
> +  [ Laszlo Boszormenyi (GCS) ]
> +  * Update fuse header name in examples.
> +  * Fix Makefile for examples (closes: #1031544).
> +
> + -- Laszlo Boszormenyi (GCS) <g...@debian.org>  Fri, 17 Mar 2023 20:51:05 
> +0100
> +
>  fuse3 (3.14.0-2) unstable; urgency=medium
>  
>    * Revert upgrade of fuse_kernel.h for not being upstreamed yet
> diff -Nru fuse3-3.14.0/debian/examples/Makefile 
> fuse3-3.14.0/debian/examples/Makefile
> --- fuse3-3.14.0/debian/examples/Makefile     2014-06-20 08:23:50.000000000 
> +0200
> +++ fuse3-3.14.0/debian/examples/Makefile     2023-03-17 20:51:05.000000000 
> +0100
> @@ -1,12 +1,16 @@
> -CFLAGS := -Wall $(shell pkg-config fuse --cflags)
> -LDFLAGS := $(shell pkg-config fuse --libs)
> +CFLAGS := -Wall $(shell pkg-config fuse3 --cflags)
> +LDFLAGS := $(shell pkg-config fuse3 --libs)
>  
> -targets = fusexmp fusexmp_fh hello hello_ll null
> +targets = cuse cuse_client hello hello_ll \
> +          invalidate_path ioctl ioctl_client \
> +          notify_inval_entry notify_inval_inode notify_store_retrieve \
> +          null passthrough passthrough_fh passthrough_ll \
> +          poll poll_client printcap
>  
> -all: $(targets)
> +%: %.c
> +     $(CC) $(CFLAGS) $< -o $@ $(LDFLAGS)
>  
> -fusexmp_fh: fusexmp_fh.c
> -     $(CC) $(CFLAGS) $(LDFLAGS) -lulockmgr $< -o $@
> +all: $(targets)
>  
>  clean:
>       rm -f *.o
> diff -Nru fuse3-3.14.0/debian/patches/series 
> fuse3-3.14.0/debian/patches/series
> --- fuse3-3.14.0/debian/patches/series        2023-02-18 07:22:30.000000000 
> +0100
> +++ fuse3-3.14.0/debian/patches/series        2023-03-17 20:51:05.000000000 
> +0100
> @@ -1 +1,2 @@
>  revert_upgrade_of_fuse_kernel.h.patch
> +update_header_name.patch
> diff -Nru fuse3-3.14.0/debian/patches/update_header_name.patch 
> fuse3-3.14.0/debian/patches/update_header_name.patch
> --- fuse3-3.14.0/debian/patches/update_header_name.patch      1970-01-01 
> 01:00:00.000000000 +0100
> +++ fuse3-3.14.0/debian/patches/update_header_name.patch      2023-03-17 
> 20:51:05.000000000 +0100
> @@ -0,0 +1,21 @@
> +Description: use new header name of fuse
> + Just rename fuse_config.h to libfuse_config.h
> +Author: Laszlo Boszormenyi (GCS) <g...@debian.org>
> +Bug-Debian: https://bugs.debian.org/1031544
> +Forwarded: no
> +Last-Update: 2023-03-17
> +
> +---
> +
> +
> +--- fuse3-3.14.0.orig/example/poll_client.c
> ++++ fuse3-3.14.0/example/poll_client.c
> +@@ -19,7 +19,7 @@
> +  * \include poll_client.c
> +  */
> + 
> +-#include <fuse_config.h>
> ++#include <libfuse_config.h>
> + 
> + #include <sys/select.h>
> + #include <sys/time.h>
> diff -Nru fuse3-3.14.0/debian/rules fuse3-3.14.0/debian/rules
> --- fuse3-3.14.0/debian/rules 2023-01-22 08:17:08.000000000 +0100
> +++ fuse3-3.14.0/debian/rules 2023-03-17 20:51:05.000000000 +0100
> @@ -54,7 +54,7 @@
>  
>  override_dh_auto_test:
>  ifeq (,$(findstring nocheck,$(DEB_BUILD_OPTIONS)))
> -ifeq (,$(findstring $(DEB_BUILD_ARCH),powerpc ppc64 sparc64 s390x))
> +ifeq (,$(findstring $(DEB_BUILD_ARCH),powerpc ppc64 sparc64 s390x hppa))
>               (cd obj-${DEB_HOST_GNU_TYPE}; python3 -m pytest test/) \
>                       || true
>  endif


-- 
Sebastian Ramacher

Reply via email to