Hi Lorenzo,

Lorenzo Puliti <plore...@disroot.org> writes:

> Package: runit-init
> Version: 2.1.2-54
> Severity: minor
> X-Debbugs-Cc: Olaf Meeuwissen <paddy-h...@member.fsf.org>, Mark
> Hindley <m...@hindley.org.uk>, plore...@disroot.org
>
> From Devuan bug #749 [1]
>
>> Every time I `poweroff` my machine, I see error message flash by that
>> complain about `halt` being called with unsupported options.  I think
>> I have tracked this down to /etc/init.d/halt making blind assumptions
>> about the options supported by the `halt` command.
>
> When runit is init, calling halt or reboot at the end of stage3 is unecessary,
> so an easy solution to silent those warnings is to skip halt and reboot
> scripts during the shutdown loop, so that reboot or poweroff is carry on
> by runit code as stage 3 returns.

Apologies if I sound a bit clueless, but if runit is *not* init, it
would still have to call halt and reboot scripts, right?

> There will be still one warning left for the -w flag but that is already
> tracked in #992648 [2].

Ack.

> I prefer not to silence the warning in shutdown.c:
>
> * It nice for the user to be warned that a used flag is noop
> * (more important) halt/reboot are called by other scripts or programs in
>   the system, and I don't have a complete picture of that, so I'm using
>   the warning to make debug easier in such situations.

Ack and let me state, for the record, that I have even less of a picture
of how all these bits fit together :-/

> Olaf, let me know if you would be unsatisfyied with the above solution;

If it solves my (wishlist) issue and does not unduly inconvenience other
use cases, I'm fine with it.

> [1] https://bugs.devuan.org/cgi/bugreport.cgi?bug=749
> [2] https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=992648

Hope this helps,
--
Olaf Meeuwissen

Reply via email to