On 3/12/23 13:54, Alejandro Colomar wrote: > Hi Paul, > > On 3/12/23 02:44, Paul Eggert wrote: >> On 2023-03-11 14:02, Alejandro Colomar wrote: >>> we should use "%s" (if we go the way of snprintf(3)). >> >> Yes, thanks for catching that. However, I came up with a better way that >> avoids snprintf (and strlcpy) entirely both here and the other place I >> used snprintf. >> >> Attached is a revised set of patches that addresses the comments you >> made and embodies my followups. > > I've applied patches 1, 2, 3, and 4 to my repo (I'll take care of them, > and forward them to the maintainers). You can rebase to > <http://www.alejandro-colomar.es/src/alx/shadow/shadow.git/log/?h=paul>
I've pushed a signed tag paul1, so you can safely check that the repo is mine (since I don't have HTTPS). <http://www.alejandro-colomar.es/src/alx/shadow/shadow.git/tag/?h=paul1> $ git show paul1 tag paul1 Tagger: Alejandro Colomar <a...@kernel.org> Date: Sun Mar 12 16:24:54 2023 +0100 First round of patches applied from Paul Eggert. -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEE6jqH8KTroDDkXfJAnowa+77/2zIFAmQN7tsACgkQnowa+77/ 2zJUNg/+OTaAFD276I8DHo/HvOtwPuKWiwcB7u0Yp4gdzkcbU/AGZ5S0xpdqbsIP IWgiR402NIPv5zfQPA/v5vg0UNHxK6pQx2vhIUWsm0awG1m+N0+4VifXFbWo+LoY bwxocWnEQJS8fIzK6YKi1CMw5++LKtx/orygZF/tfEQIVSTey/AktjaQY6OM4Yrb U4HN9w0M5PELuyUl5v92XGSmSPxUDR5b3UdJ88Pz4wW1mnSOl4DpDdmFhVjzRkQp 1MBdB2OM4l5oCxSWPguYTyRYF2qOdVbZhxujPx0ob8uOzV78+plEas5gYYRxtIwo ymcPLvet7qXfr5JE0I8vIt8AIXBRdyvdWydyaZOQecwCr5gqW0XTmo84cVzcTJ4q 4wqpJ4N9MODiolDYhDr97CN2D9DY0jeKvFj1vTdy6lC8nxWR9E55TuFXur7AEXTJ TP9IxBK/7IoR7D9MidSmyq9zuHcDr3lkMEvHWLDfzYoFsI5fNeumyW52ylOUs7CV u6BpWQpX/bPvUR+p1KuEPnP/nAzDpjDdlWWmd6cdTvu1H1JJCyFwjO7GVhts0JLF LkxFiwHF8XmEz6g5HOYL16LpuClUtIAOEP9YXCpaiF1jROHjkErFm2YjEbtQMSZD u5Ea8or9RVFQTWgbRHS4+SfmN8292gR9QxmU6Xhxmz3CldiqypM= =aDa2 -----END PGP SIGNATURE----- commit 67be4a8f2585c8af423e358efc4934291880a900 (HEAD -> paul, tag: paul1, alx/paul) Cheers, Alex > > For the rest of the patches, I'll send some comments. > > Thanks! > > Alex > -- <http://www.alejandro-colomar.es/> GPG key fingerprint: A9348594CE31283A826FBDD8D57633D441E25BB5
OpenPGP_signature
Description: OpenPGP digital signature
