Thank you for the considerations made in my review and excellent work with your review. I learned a lot from your work.
waiting for a sponsor to upload. On Tue, Feb 21, 2023 at 2:22 AM Boian Bonev <bbo...@ipacct.com> wrote: > Hi, > > First thing to change (after the missing binary) is the description - the > tool > no longer executes and parses tcpdump's output, instead it uses libpcap > directly to get the packets. The man page needs the same correction. > > The build completely ignores the default hardening and optimization flags. > This > breaks both cross and reproducible builds. > > tcpdump should be removed from Depends. > > Isn't it better to depend on libpcap-dev? (libpcap0.7-dev isn't in any > supported release) > > Current standards are 4.6.2. > > d/copyright may benefit from a DEP5 conversion. > > Now I see that there are 3 open bugs, maybe at least two or even all can be > fixed by this upload? > > I have several patches for this tool hanging around since 2013, I did try > to > send them to upstream back then but they either got lost or ignored. All of > them are fixing behavioral bugs. > > I think it is a good idea to add these patches while doing the QA upload. I > need to add the proper headers and will post after an ACK. > > -- > With best regards, > b. >
