On Fri, 17 Feb 2023 12:59:23 +0100 Matteo Bini <matteo...@tiepi.it> wrote:
> Hi Plasma, > thanks for the patch! Happy to help. > Before applying your fix, I would like to ask you what is the > difference between calling `$(MAKE)` and `dh_auto_build --`. dh_auto_build, as a part of debhelper, automatically modifies the build environment and sets makeflags before running the program's Makefile. Importantly in this case, it checks the environment variable DEB_BUILD_OPTIONS to see if it contains a "parallel=n" tag. If it does, debhelper adds '-j' to the makeflags with the associated value n. If DEB_BUILD_OPTIONS doesn't exist or doesn't contain a "parallel=n" tag, debhelper sets the makeflags to build with as many CPU threads are available. Running make directly using $(MAKE) only handles DEB_BUILD_OPTIONS properly with additional boilerplate code. See Debian Policy Section 4.9.1 (link below) for an example. In general it's much easier to let debhelper do the heavy lifting rather than having to write a bunch of the same boilerplate for each package. https://www.debian.org/doc/debian-policy/ch-source.html#debian-rules-and-deb-build-options > Moreover I was wondering if your patch could make davegnukem build > reproducibly, because now it does not. I'm not sure. I don't think so. I skimmed the build logs for davegnukem, but I wasn't able to tell what was keeping it from building reproducibly, sorry. > This is one of my first packages, so please forgive my ignorance. I > really appreciate your help. Ignorance is easy to forgive in anyone willing and eager to learn. :-) -- Plasma
