cc Jason On Mon, 20 Feb 2023 at 15:22, Michael Tokarev <m...@tls.msk.ru> wrote: > > 20.02.2023 16:10, Ard Biesheuvel wrote: > > Package: qemu-system-x86 > > Version: 1:7.2+dfsg-3 > > Severity: normal > > X-Debbugs-Cc: a...@kernel.org > > > > Dear Maintainer, > > > > The latest version of qemu-system-x86 incorporates > > > > x86-don-t-let-decompressed-kernel-image-clobber-setu.patch > > > > which is a cherry pick of a problematic qemu patch, and needs > > to be dropped. > > > > The result is that booting a Linux kernel using OVMF firmware > > and the -kernel command line argument no longer works, and > > instead, other boot options are attempted in turn, which > > generally results in no boot at all, or the wrong boot option > > being chosen. > > In my case, this cherry-pick did the opposite: it allowed me to boot > one of the latest 6.1 kernels in qemu with -kernel which was otherwise > unbootable. Someone else suggested this patch to me, it fixed boot for > them too. > > hwell. > > > Related discussion: > > https://lore.kernel.org/all/20221228143831.396245-1-ja...@zx2c4.com/ > > The whole patch set which introduced the change which is being worked > around in this patch - whole thing should be dropped instead, see > https://lore.kernel.org/all/20230208211212.41951-1-...@redhat.com/ > > I'm not sure what to. It breaks one way or another, and there's no > solution so far. >
All my linux-efi jobs in kernelci have started failing for x86 due to a QEMU upgrade to this version, so I would prefer to just revert this patch. It seems everyone on the thread agrees that it is not an improvement. I did not receive any reports regarding v6.1 boot failures on x86: are you booting with OVMF? We added a patch to v6.0 [0] to deal with bogus setup_data when doing EFI boot, so v6.1 should have this change too. Jason, any ideas? [0] commit 63bf28ceb3ebbe76048c3fb2987996ca1ae64f83 Author: Ard Biesheuvel <a...@kernel.org> Date: Thu Aug 4 15:39:48 2022 +0200 efi: x86: Wipe setup_data on pure EFI boot