El 7/2/23 a las 4:04, Steven Robbins escribió:
On Sunday, February 5, 2023 7:04:26 P.M. CST Santiago Vila wrote:
The tests do not even *run* on the buildds, because they are skipped.
Indeed! I must have skipped over that output :-)
But I think the larger point remains: there is no build failure in practice.
What is different in your environment that makes it fail?
The difference is that my environment is actually able to load the kernel
modules required to run the tests.
So, the ordinary user who wants to rebuild the package with or without changes
will be able to run the tests and they will see that it does not work at all
(command "ssh" is used for the tests and there is not even a build-depends
on openssh-client!).
My feeling is that the usual maintainers for this package have never built
this correctly in a chroot using dpkg-buildpackage in a clean chroot, or maybe
they have always used pbuilder and never noticed that the tests are skipped.
I'm changing my suggestion to disable the tests which do not work
using "@pytest.mark.skip", as there would still be the problem of using
ssh and requiring a build-depends.
The most simple and effective way to fix this (at this point of the
release cycle) is to skip the tests altogether for everybody, as in
the attached patch.
Dear maintainers: Would be possible to apply the attached patch?
(temporarily disable the tests until we find a way to do it right).
(Cc: to all people who did an upload in the last two years).
Thanks.
--- a/debian/changelog
+++ b/debian/changelog
@@ -1,3 +1,9 @@
+sshfs-fuse (3.7.3-2) unstable; urgency=medium
+
+ * Temporarily disable test suite until we can do it right. Closes: #1028163.
+
+ -- Dmitry Smirnov <only...@debian.org> Tue, 07 Feb 2023 11:00:00 +0100
+
sshfs-fuse (3.7.3-1) unstable; urgency=medium
* New upstream release.
--- a/debian/rules
+++ b/debian/rules
@@ -10,6 +10,6 @@ override_dh_auto_clean:
rm -rf test/__pycache__ test/.pytest_cache
override_dh_auto_test:
-ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
- python3 -m pytest test/
-endif
+# ifeq (,$(filter nocheck,$(DEB_BUILD_OPTIONS)))
+# python3 -m pytest test/
+# endif
