Hi,

Alexander Dalm <a.dalm2...@googlemail.com> (2023-02-05):
> Hi Cyril,
> 
> > Attaching patches is best done by using git diff / git format-patch.
> sure, but this is an inconvenience for me as outside contributor and might
> deter other ones as well.
> I'm sure you and other core maintainers can import one file with ease...

The burden goes both ways. Sending your file over the wall is easy for
you but that means we end up reviewing this huge diff, without any kind
of logical split between changes:

 check-missing-firmware.sh | 185 ++++++++++++++++++++++++++++++++++------------
 1 file changed, 139 insertions(+), 46 deletions(-)

Anyway, playing with IFS is a recipe for a disaster, and why are we even
talking about files with space characters in the first place?

This is a little sad because there might be interesting bits in there
(like side-stepping moutmedia which is apparently not quite doing what
some users might expect, see #1029543, #1029962).


Cheers,
-- 
Cyril Brulebois (k...@debian.org)            <https://debamax.com/>
D-I release manager -- Release team member -- Freelance Consultant

Attachment: signature.asc
Description: PGP signature

Reply via email to