Package: simple-cdd
Version: 0.6.8
Severity: normal
User: de...@kali.org
Usertags: origin-kali
X-Debbugs-Cc: vagr...@debian.org

Dear Maintainer,

Looking at tools/mirror/reprepro [1], I see that this script runs
'reprepro update' in a loop, until reprepro_retries (default: 20) is
reached.

However, it's a bit strange that, if ever reprepro_retries is reached,
the code doesn't error out with a message such as "There are still
dependencies missing after $i attempts!". Instead, the script silently
keeps going, and exits with zero, as if there was no problem.

I'd suggest to either:
- error out when reprepro_retries is reached, as suggested above.
- if it's not considered an error, at least print a message to say that
  reprepro_retries was reached, and clarify that it's not a problem.

This is not a theoretical situation. I looked at the logs from the Kali
Linux daily builds, and for some builds it took 20 attempts, so it seems
likely that for some builds it would have taken more attempts.

I can submit a patch if needed,

Thanks!

[1]: 
https://salsa.debian.org/debian/simple-cdd/-/blob/master/tools/mirror/reprepro

Reply via email to