Hi Nilesh, Nilesh Patra, on 2023-01-16: > https://github.com/gem-pasteur/macsyfinder/issues/58 > > I've now added a comment saying that the patch fixes these random > issues. I am tempted to merge this patch and upload, but I am not 100% > confident if it is correct. And hence, a review would be nice (Etienne, > if you are reading this if you could check) or I'll wait for > upstream action. They seem kind of active.
I reread the code without and with the patch, and I think I begin to make sense of what could have happened: there is a small probability to try to join on the main thread which I think is not supposed to finish at this point, thus likely causing the error. The probability grows with the reduction of the core count. Also, it seems certain CPU may have allow more fine grained threading models than others, explaining the discrepancy between different brands. Your change makes sense to me and should render the code robust. I verified the build is not flaky after a dozen builds in the environment where I saw the error previously. This looks good to me, and I learned a couple of things today. > Again, thank you Santiago! Seconded! Thanks Lucas for the report, Santiago for the resource to reproduce the issue, and Nilesh for actually fixing it! Have a nice day, :) -- Étienne Mollier <emoll...@emlwks999.eu> Fingerprint: 8f91 b227 c7d6 f2b1 948c 8236 793c f67e 8f0d 11da Sent from /dev/pts/1, please excuse my verbosity. On air: Canvas Solaris - Zero Point Field
signature.asc
Description: PGP signature
