Control: tag -1 upstream

Hi Andrew,

andrew bezella <and...@diatribes.org> writes:

> ## Path:           System/File systems/btrfs
> ## Type:           string(none,daily,weekly,monthly)
> ## Default:        "weekly"
> ## ServiceRestart: btrfsmaintenance-refresh
> #
> # Frequency of periodic balance.
> #
> # The frequency may be specified using one of the listed values or
> # in the format documented in the "Calendar Events" section of 
> systemd.time(7),
> # if available.
> BTRFS_BALANCE_PERIOD="weekly"
>
> however /lib/systemd/system/btrfs-balance.timer has:
> [Timer]
> OnCalendar=monthly
>
> it would seem that either the value/note in /etc/default/btrfsmaintenance
> or the OnCalendar value in btrfs-balance.timer should be updated to match
> the other.
>

Oh yeah!  I had forgotten about this minor issue.  The reason I hadn't
harmonised the files, doing this implicitly says that I (and Debian)
might recommend weekly balanced, or recommend monthly balances.

From what I've been able to gather, metadata balances have been
considered to be actively harmful for some time; This is mostly at the
level of tribal knowledge on the linux-btrfs mailing list.  It's also
the case that empty block groups are now automatically reclaimed by the
kernel, so a periodic balance only seems to be useful in
space-constrained situations where a lot of [meta]data churn occurs.

Thus, if I do anything, I'm inclined to set the period for balance to
"none" everywhere.

Also, what do you think about enabling the systemd patch watcher, so
that the timers are updated automatically when
/etc/default/btrfsmaintenance is modified?

Best,
Nicholas

Attachment: signature.asc
Description: PGP signature

Reply via email to