Package: pushpin

pushpin build-depends on librust-clap+derive-dev and librust-clap+term-size,
librust-clap+default-dev is both an uninstallable cruft physical package, and a
virtual package provided by both librust-clap-dev, librust-clap-3-dev.
librust-clap+term-size-dev is both an uninstallable cruft physical package
and a virtual package provided by librust-clap-2-dev.

Since clap version 3 and 4 don't have a term-size feature this does not 
currently
risk a FTBFS, but we would still preffer you dependended explicitly on the
version of clap you need for a few reasons. Firstly because it makes it easier
to keep track of what software is using what version of clap. Secondly because
we would like to see the cruft packages decrufted as I belive they are the cause
of spurious puiparts regressions in the testing migration report for the 
rust-clap
package. Finally it's possible that a future version of clap may reintroduce a
term-size feature in which cause your package would risk a FTBFS.

Also you don't seem to use the term-size feature directly, but in fact use the
wrap_help feature. Thus your dependencies should be librust-clap-2+default-dev
and librust-clap-2+wrap-help-dev.

A debdiff is attatched, if I get no response
I will likely NMU this in a week or so.

diff -Nru pushpin-1.36.0/debian/changelog pushpin-1.36.0/debian/changelog
--- pushpin-1.36.0/debian/changelog     2023-01-06 22:06:32.000000000 +0000
+++ pushpin-1.36.0/debian/changelog     2023-01-14 11:14:56.000000000 +0000
@@ -1,3 +1,10 @@
+pushpin (1.36.0-1.1) unstable; urgency=medium
+
+  * Non-maintainer upload.
+  * Update build-dependencies on clap packages to reflect cargo dependencies.
+
+ -- Peter Michael Green <plugw...@debian.org>  Sat, 14 Jan 2023 11:14:56 +0000
+
 pushpin (1.36.0-1) unstable; urgency=medium
 
   * New upstream version
diff -Nru pushpin-1.36.0/debian/control pushpin-1.36.0/debian/control
--- pushpin-1.36.0/debian/control       2023-01-06 22:06:32.000000000 +0000
+++ pushpin-1.36.0/debian/control       2023-01-14 11:13:53.000000000 +0000
@@ -2,7 +2,7 @@
 Section: net
 Priority: optional
 Maintainer: Jan Niehusmann <j...@debian.org>
-Build-Depends: debhelper (>= 11), qtbase5-dev, qt5-qmake, qtchooser, 
libzmq3-dev (>= 2.0), pkg-config, qconf, cargo (>= 0.43), 
librust-clap+default-dev, librust-clap+term-size-dev, librust-log-dev, 
librust-serde-dev, librust-serde-json-dev, librust-zmq-dev, 
librust-serde-derive-dev, librust-base64-dev, librust-slab-dev, 
librust-jsonwebtoken-dev
+Build-Depends: debhelper (>= 11), qtbase5-dev, qt5-qmake, qtchooser, 
libzmq3-dev (>= 2.0), pkg-config, qconf, cargo (>= 0.43), 
librust-clap-2+default-dev, librust-clap-2+wrap-help-dev, librust-log-dev, 
librust-serde-dev, librust-serde-json-dev, librust-zmq-dev, 
librust-serde-derive-dev, librust-base64-dev, librust-slab-dev, 
librust-jsonwebtoken-dev
 Standards-Version: 4.1.4
 Homepage: https://github.com/fanout/pushpin
 Vcs-Git: https://salsa.debian.org/jan/pushpin.git

Reply via email to