Control: severity -1 serious Control: tags -1 - moreinfo unreproducible Hi Cédric (and all)!
On Wed, Nov 17, 2021 at 09:27:19AM +0100, Cédric Boutillier wrote:
> tags 996234 + unreproducible
> thanks
This error is now visible on reproducible builds server [1] and on the CI
server for some architectures [2].
Comparing the last successful log [3] and the first failed log [4], I see that
the former installs ruby-commonmarker, while the latter does not. Probably
because ruby-html-pipeline no longer depends on it [5].
And file lib/github/markup/markdown.rb has the following code:
MARKDOWN_GEMS = {
"commonmarker" => proc { |content|
CommonMarker.render_html(content, :GITHUB_PRE_LANG, [:tagfilter,
:autolink, :table, :strikethrough])
},
"github/markdown" => proc { |content|
GitHub::Markdown.render(content)
},
"redcarpet" => proc { |content|
Redcarpet::Markdown.new(Redcarpet::Render::HTML).render(content)
},
"rdiscount" => proc { |content|
RDiscount.new(content).to_html
},
"maruku" => proc { |content|
Maruku.new(content).to_html
},
"kramdown" => proc { |content|
Kramdown::Document.new(content).to_html
},
"bluecloth" => proc { |content|
BlueCloth.new(content).to_html
},
}
So it prefers commonmarker when it's available, and falls back to another
backend if it is not. And it looks like the test was written specifically
for commonmarker.
(Build-)Depending on ruby-commonmarker explicitly instead of the list of
four alternatives should fix this issue.
Please note that #1013383 is a separate issue. It happens only with docutils
>= 0.18 because it slightly changed HTML output. This docutils version is
still only in experimental, but I am going to upload it to unstable soon.
To fix it, you will need to cherry-pick first two hunks of [6].
[1]:
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/ruby-github-markup.html
[2]: https://ci.debian.net/packages/r/ruby-github-markup/unstable/i386/
[3]:
https://ci.debian.net/data/autopkgtest/unstable/i386/r/ruby-github-markup/28863476/log.gz
[4]:
https://ci.debian.net/data/autopkgtest/unstable/i386/r/ruby-github-markup/30093064/log.gz
[5]:
https://salsa.debian.org/ruby-team/ruby-html-pipeline/-/commit/f7dc53509439313e
[6]: https://github.com/github/markup/commit/2de4aa63c419d1cc
--
Dmitry Shachnev
signature.asc
Description: PGP signature
