retitle -1 xtide: FTBFS (invalid conversion from ‘char**’ to
‘const char**’)
severity -1 serious
thanks
On Tue, 20 Dec 2022 08:55:53 +0000 Eric Long <[email protected]> wrote:
> Source: xtide
> Version: 2.15.2-1.1
> Severity: important
> Tags: ftbfs patch
> Justification: fails to build from source (but built successfully in
the past)
> X-Debbugs-Cc: [email protected]
>
> Dear maintainer(s),
>
> xtide failed to build on riscv64 due to invalid conversion:
>
> ```
> xxLocationList.cc: In member function ‘void
xxLocationList::listChanged()’:
> xxLocationList.cc:90:34: error: invalid conversion from ‘char**’
to ‘const char**’ [-fpermissive]
> 90 | XawListChange (list->widget(), stringList, 0, 0, 1);
> | ^~~~~~~~~~
> | |
> | char**
> In file included from xtide.hh:45,
> from xxLocationList.cc:21:
> /usr/include/X11/Xaw/List.h:170:27: note: initializing argument 2
of ‘void XawListChange(Widget, const char**, int, int, Boolean)’
> 170 | _Xconst char **list,
> | ^
> make[2]: *** [Makefile:1136: xxLocationList.o] Error 1
> ```
>
> Full buildd log:
https://buildd.debian.org/status/fetch.php?pkg=xtide&arch=riscv64&ver=2.15.2-1.1%2Bb1&stamp=1671253782&raw=0
>
> This can be fixed by explicitly converting types on riscv64, for
which I've
> included a patch. If more help is needed, please let me know.
>
> Cheers,
> Eric
It also failed building on amd64, and potentially other platforms. I've
removed "riscv64" from title and set severity to serious, and the newly
attached patch can be applied to all platforms.
Cheers,
Eric
--- a/xxLocationList.cc
+++ b/xxLocationList.cc
@@ -87,7 +87,7 @@
void xxLocationList::listChanged() {
- XawListChange (list->widget(), stringList, 0, 0, 1);
+ XawListChange (list->widget(), (const char**)stringList, 0, 0, 1);
}
