On Mon, Dec 12, 2022 at 09:41:38AM +0300, Michael Tokarev wrote:
>
> I pushed "mjt" branch yesterday to the repository (without pristine-tar
> and upstream pieces so far) which updates f2fs to 1.15 and adds minor
> cleanups to d/rules. Please take a look.
Thanks! The main thing I will note is that it appears that you
checked in f2fs-tools v1.15.0 as a squashed commit. That is, the
signle commit d0ba994589b5 seems to be a delta between v1.14.0 and
v1.15.0. What I've done instead is do a git fetch of the upstream git
repo[1] and then performed a "git merge v1.15.0". This allows the
full upstream git history to be in the debian branch, which makes
future cherry-picks and merges to be easier.
[1] git://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs-tools.git
I've then rebased the rest of your changes from the salsa/mjt branch
on top, and then added a commit to change the distribution from
"UNRELEASED" to "unstable".
After adding pristine-tar, "gbp buildpackage" seems to work just fine.
I'm in the middle of running a quick regression test using
"gce-xfstests -c f2fs/default -g auto". If that is clean, I'll do a
formal signed build using dgit.
> This is a known issue. I've faced it a few times myself, though in
> my case I didn't want to add more work for ftp-masters and tried to
> avoid soname bump.
Yeah, unfortunately, the library communicates with its callers
(including the specification of the device name, etc.) in the global
variable:
struct f2fs_configuration c;
So unfortunately, there are soname bumps needed pretty much at every
single release, because the library API design was, well.... the sort
of thing you would expect for a flash FTL firmware programmer. :-(
> So, let's process 1.15. I don't really care much about the lack
> of shared library at this time. Please take a look. I'm not the
> first-day Debian developer, but maybe there's something specific
> to this package or your habits which I didn't think about.
I think you did a great job! I'll let you know how my regression test
works out. (gce-xfstests is more of a kernel test than a userspace
test, but it's the best that we have for f2fs-tools....)
- Ted
