On Wed, 7 Dec 2022, 01:46 Mathias Gibbens, <gib...@debian.org> wrote:
> On Tue, 2022-12-06 at 23:55 +0000, Richard Lewis wrote: > > On Tue, 6 Dec 2022 at 01:34, Richard Lewis > > <richard.lewis.deb...@googlemail.com> wrote: > > > I didnt do a proper patch yet > > > > And now i have: > > https://salsa.debian.org/debian/logcheck/-/merge_requests/15 > > Thanks, Richard! I've made a few comments on that merge request. If > there's no other comments by the end of the week I'll plan to merge it > over the weekend. > thanks - i will work through. (i cant easily make changes in git/salsa until this evening) Also, you had commented > > > In the replacement, I we want the old prefix _first_ for future- > > proofing: rsyslog is being demoted in priority: it may still be > > pulled in as dependencies, more and more we will see systems without > > rsyslog installed at all - all the logging will be in the journal. > > So to remain useful, logcheck will need to enable checking of the > > systemd journal as well as /var/log/syslog. And the journal lines are > > extracted by logcheck in the "old" format. So I think we should do > > this change with that in mind. > > I don't want to accidentally loose this -- could you make sure > there's a bug in the BTS to remind us to properly enable checking > systemd's journal > i will report later (if noone else does). there is a small patch i have to stop logcheck going back over the entire journal (and then beeing OOM-killed) when checking is first enabled that i will include too. - glad to see some momentum in this package! (i will have to restrain myself from trying to fix all the bugs at once!)