Source: osmnx
Version: 1.2.2+ds-2
Severity: important
Tags: upstream ftbfs
User: debian-...@lists.debian.org
Usertags: shapely-2.0
Control: forwarded -1 https://github.com/gboeing/osmnx/pull/891
Dear Maintainer,
Your package FTBFS with python3-shapely from experimental:
============================= test session starts
==============================
platform linux -- Python 3.10.8, pytest-7.1.2, pluggy-1.0.0+repack --
/usr/bin/python3
cachedir: .pytest_cache
rootdir: /build/osmnx-1.2.2+ds
collecting ... collected 0 items / 1 error
==================================== ERRORS
====================================
_____________ ERROR collecting debian/tests/test_osmnx_offline.py
______________
ImportError while importing test module
'/build/osmnx-1.2.2+ds/debian/tests/test_osmnx_offline.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/usr/lib/python3.10/importlib/__init__.py:126: in import_module
return _bootstrap._gcd_import(name[level:], package, level)
debian/tests/test_osmnx_offline.py:35: in <module>
import osmnx as ox
osmnx/__init__.py:3: in <module>
from ._api import *
osmnx/_api.py:17: in <module>
from .geometries import geometries_from_address
osmnx/geometries.py:21: in <module>
from shapely.geos import TopologicalError
E ImportError: cannot import name 'TopologicalError' from 'shapely.geos'
(/usr/lib/python3/dist-packages/shapely/geos.py)
=========================== short test summary info
============================
ERROR debian/tests/test_osmnx_offline.py
!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection
!!!!!!!!!!!!!!!!!!!!
=============================== 1 error in 7.73s
===============================
The attached patch fixes the issue.
Kind Regards,
Bas
diff -Nru osmnx-1.2.2+ds/debian/changelog osmnx-1.2.2+ds/debian/changelog
--- osmnx-1.2.2+ds/debian/changelog 2022-12-03 12:02:14.000000000 +0100
+++ osmnx-1.2.2+ds/debian/changelog 2022-12-06 14:51:41.000000000 +0100
@@ -1,3 +1,10 @@
+osmnx (1.2.2+ds-2.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Add patch to fix FTBFS with Shapely 2.0.
+
+ -- Bas Couwenberg <sebas...@debian.org> Tue, 06 Dec 2022 14:51:41 +0100
+
osmnx (1.2.2+ds-2) unstable; urgency=medium
* Debianization:
diff -Nru osmnx-1.2.2+ds/debian/patches/series
osmnx-1.2.2+ds/debian/patches/series
--- osmnx-1.2.2+ds/debian/patches/series 2021-11-04 16:28:16.000000000
+0100
+++ osmnx-1.2.2+ds/debian/patches/series 2022-12-06 14:51:41.000000000
+0100
@@ -1,3 +1,4 @@
adhoc-fix-elevation-multiprocessing.patch
debianization.patch
debianization-tests-extra.patch
+shapely.patch
diff -Nru osmnx-1.2.2+ds/debian/patches/shapely.patch
osmnx-1.2.2+ds/debian/patches/shapely.patch
--- osmnx-1.2.2+ds/debian/patches/shapely.patch 1970-01-01 01:00:00.000000000
+0100
+++ osmnx-1.2.2+ds/debian/patches/shapely.patch 2022-12-06 14:51:41.000000000
+0100
@@ -0,0 +1,15 @@
+Description: Fix ImportError with Shapely 2.0.
+Author: Bas Couwenberg <sebas...@debian.org>
+Forwarded: https://github.com/gboeing/osmnx/pull/891
+
+--- a/osmnx/geometries.py
++++ b/osmnx/geometries.py
+@@ -18,7 +18,7 @@ from shapely.geometry import LineString
+ from shapely.geometry import MultiPolygon
+ from shapely.geometry import Point
+ from shapely.geometry import Polygon
+-from shapely.geos import TopologicalError
++from shapely.errors import TopologicalError
+ from shapely.ops import linemerge
+ from shapely.ops import polygonize
+
