Package: pbuilder
Version: 0.122
Severity: wishlist
Tags: patch

The post-build "B" hooks are likely used to install lintian, linda (as
the included examples suggest), and possibly anything else to test the
just-built package. It would be nice if the aptcache were saved after
the hooks run.

This would be a really trivial, non-intrusive change. The patch also
adds a comment to save_aptcache, to document that it is safe to call it
multiple times (I've looked at the code: it is).

Best Regards,
Danilo

-- 
Danilo Piazzalunga                     +--------------------+
PGP Key available at subkeys.pgp.net   | Linux User #245762 |
Fingerprint: D018 815E 8C7F 2AE2 5565  | ICQ #105550412     |
             0C36 B5F6 DB20 B800 CB9F  +--------------------+
diff -Nru pbuilder-0.122.orig/pbuilder-buildpackage 
pbuilder-0.122/pbuilder-buildpackage
--- pbuilder-0.122.orig/pbuilder-buildpackage   2005-02-13 07:57:29.000000000 
+0100
+++ pbuilder-0.122/pbuilder-buildpackage        2005-02-26 12:19:59.883918952 
+0100
@@ -127,6 +127,7 @@
 
 trap umountproc_cleanbuildplace exit
 executehooks "B"
+save_aptcache
 trap cleanbuildplace exit
 umountproc
 
diff -Nru pbuilder-0.122.orig/pbuilder-modules pbuilder-0.122/pbuilder-modules
--- pbuilder-0.122.orig/pbuilder-modules        2005-02-13 07:52:44.000000000 
+0100
+++ pbuilder-0.122/pbuilder-modules     2005-02-26 12:19:55.782542456 +0100
@@ -302,6 +302,7 @@
 
 function save_aptcache() {
     # save the current aptcache archive
+    # it is safe to call this function multiple times
     local doit
     if [ -n "$APTCACHE" ]; then
        echo "Copying back the cached apt archive contents"

Reply via email to