Package: libcamera
Version: 0.0.1-4

I'm working on getting libcamera promoted to main in Ubuntu, one of the requirements is to have tests (build and autopkgtest). The package currently override the dh_auto_test target to ignore those, it seems an old change and isn't really documented and I'm wondering if the rational still stands? Having tests as part of the build (and as autopkgtests) would also benefit Debian.

I'm attaching a trivial patch to enable the tests as part of the build. Doing that on Ubuntu is leading to 3 failures (seems to be due to the env, it fails on the builders or in a pbuilder env but not in a lxc container) so that's an issue to sort out before uploading.

I've reported the issue upstream on https://bugs.libcamera.org/show_bug.cgi?id=173 as a start point. I will update the report once there is a fix (or maybe skip those 3 tests to start?)

Cheers,

diff -Nru libcamera-0.0.1/debian/changelog libcamera-0.0.1/debian/changelog
--- libcamera-0.0.1/debian/changelog	2022-10-26 18:44:01.000000000 +0200
+++ libcamera-0.0.1/debian/changelog	2022-11-24 21:33:29.000000000 +0100
@@ -1,3 +1,9 @@
+libcamera (0.0.1-5) UNRELEASED; urgency=medium
+
+  * debian/rules: enable the upstream tests as part of the build
+
+ -- Sebastien Bacher <seb...@ubuntu.com>  Thu, 24 Nov 2022 21:33:29 +0100
+
 libcamera (0.0.1-4) unstable; urgency=medium
 
   * Mark liblttng-ust-dev and libudev-dev as linux-only, add more optional
diff -Nru libcamera-0.0.1/debian/.gitignore libcamera-0.0.1/debian/.gitignore
--- libcamera-0.0.1/debian/.gitignore	2022-10-26 18:44:01.000000000 +0200
+++ libcamera-0.0.1/debian/.gitignore	1970-01-01 01:00:00.000000000 +0100
@@ -1,2 +0,0 @@
-!patches/
-!*.patch
diff -Nru libcamera-0.0.1/debian/rules libcamera-0.0.1/debian/rules
--- libcamera-0.0.1/debian/rules	2022-10-26 18:44:01.000000000 +0200
+++ libcamera-0.0.1/debian/rules	2022-11-24 21:33:13.000000000 +0100
@@ -13,16 +13,13 @@
 	dh_auto_configure -- \
 		--libexecdir=lib/${DEB_HOST_MULTIARCH} \
 		-Dv4l2=true \
+		-Dtest=true \
 		$(empty)
 
 override_dh_install:
 	mv debian/tmp/usr/share/doc/libcamera-0.* debian/tmp/usr/share/doc/libcamera-doc
 	dh_install -X/.doctrees/
 
-.PHONY: override_dh_auto_test
-override_dh_auto_test:
-
-
 .PHONY: licensecheck
 licensecheck:
 	licensecheck --deb-machine -r * \

Reply via email to