On 17 November 2022 8:38 PM, Michael Tokarev <m...@tls.msk.ru> wrote: > Do you have ability to compile samba? If yes (maybe with a debian package), > can you please try the attached patch? It removes the useless and actually > wrong check for the off_t overflowing size_t. > Attachments: > * fruit-disable-useless-size_t-overflow-check.patch
Thanks for the patch Michael, I compiled and ran and although it got out of the disk size functions this time, it still slipped up with ../../source3/smbd/service.c:787(make_connection_snum) make_connection_snum: canonicalize_connect_path failed for service TimeMachineBackup, path /mnt/HDD/TimeMachine I do appreciate you cutting this patch for this issue, however I feel like I've been down this road before with these issues. Push a fix here, and if a new issue doesn't pop up over there straight away, give it a version or three and it will eventually. Hence my reference to whack-a-mole. As Andrew points out, this is somewhat outlying as test-cases go. There are few people wanting to rebuild a 32-bit instance of their backup mechanism for each point revision of a large and actively-developed service like samba. I see no reason, personally, to push for developer attention when the solution is as simple as 'switch to 64-bit OS', and then even OLD versions in all the repos work just fine. Although I do not have statistics to hand, I feel that we must be far enough along the migration curve on the journey from 32- to 64-bit systems, especially when it comes to a core-yet-commodity infrastructure service like samba, to warrant letting go of legacy. Thanks for your good will and effort, nonetheless.
