Quoting Peter Green (2022-11-11 09:04:34) > The rust-criterion package has inconsistent dependencies on the cast > crate, the dependency in the main Cargo.toml is on version 0.3, but > the dependencies in the debian packaging and in the embedded copy of > the criterion-plot crate are at 0.2 > > I have updated the cast crate in Debian to 0.3, and prepared an update > for the rust-criterion package to use 0.3 consistently. I tested that > the package built succesfully and the autopkgtests passed with these > changes.
Thanks! I am now applying main parts of your proposed patch to the git repo (only locally for now - will push when I have it in working shape). I also extended the embedded patch 0000 to the full original upstream patch (turns out all of it is relevant for us), and adjusted to properly use DEP-3 patch headers (helpful that you referenced upstream patch, but for future sake beware especially to properly credit the author: You are at most co-author when cherry-picking patched done by others, and in most cases only reviewer). My work on other packages (rust-test-case) recently revealed that my approach to embedding crates is broken, so I will do some more poking to get it to not only succeed building on its own but also builds as dependency of other Rust crates. > While working on the fix, I discovered the clean target wasn't > cleaning up properly, so I fixed it to do so. I have left that part out for now, as that sounds like a general flaw in dh-cargo that I will try identify and fix (instead of papering over it). Thanks for pointing it out! - Jonas -- * Jonas Smedegaard - idealist & Internet-arkitekt * Tlf.: +45 40843136 Website: http://dr.jones.dk/ * Sponsorship: https://ko-fi.com/drjones [x] quote me freely [ ] ask before reusing [ ] keep private
signature.asc
Description: signature
