On Mon, Oct 31, 2022 at 10:44 AM Gregor Jasny <gja...@googlemail.com> wrote: > > Hi Sudip, > > thanks for working on the patch! > > On 10/30/22 10:43 AM, Sean Young wrote: > > On Sat, Oct 29, 2022 at 11:17:03PM +0100, Sudip Mukherjee wrote: > >>>> Sean, would you be able to port the existing code to libbpf 1.0? I > >>>> noticed > >>>> that the current code already triggers deprecation warnings with libbpf > >>>> 0.8.0. > >>> > >>> This needs porting, I'll add it to my todo list. > >> > >> Can you please test the attached patch and confirm that it does not break > >> any of the functionality. This is the only one now which is blocking me > >> from requesting libbbpf transition. > > > > That looks great, I'll give some good testing. Thanks for writing this > > patch. > > > > The way to get this merged upstream is to send to > > linux-me...@vger.kernel.org > > and then get a review from the wider community. > > Will you handle upstreaming it? Unfortunately, I don't have any Infrared > Receiver hardware, anymore and cannot test it. So I'll wait for an ACK > by Sean before applying it.
Sure, I was planning to send it today/tomorrow. > > One thing I miss in the patch is tightening the pkg-config rule to a > minimum required version which provides LIBBPF_OPTS. Proper place would > be here: > > https://git.linuxtv.org/v4l-utils.git/tree/configure.ac#n567 Ok, I might need help for this one. I will first check what will be the minimum libbpf version required for this change. afaik, libbpf/0.8 is ok with these changes. -- Regards Sudip
