On 2016-06-27, Reiner Herrmann wrote:
> While working on the "reproducible builds" effort [1], we have noticed
> that mod-dnssd could not be built reproducibly.
> The README file generated with lyxn contains differently translated
> lynx-output depending on locale/language settings.
>
> The attached patch fixes this by using 'C' as the used language.

The locales issue does not appear to affect the locales currently used
on tests.reproducible-builds.org, but I was able to sometimes reproduce
the issue with reprotest depending on which locale reprotest used.

I've attached simpler patches which just avoid using lynx by passing
--disable-lynx to configure and removing lynx from build-depends, as
using lynx also embeds build paths in a way that makes the README
reference files that do not even exist:

  
https://tests.reproducible-builds.org/debian/rb-pkg/unstable/amd64/diffoscope-results/mod-dnssd.html

  file:///build/1st/mod-dnssd-0.6/doc/README.html#license
  vs.
  file:///build/2/mod-dnssd-0.6/2nd/doc/README.html#license

The package does not even ship a README.html, as this is a byproduct of
using lynx on the generated .html file to dump a plain-text README.

By not using lynx, it simply ships the provided readme.

I intend to NMU with these patches applied, though will likely use
DELAYED/10 to give time for the maintainer to respond.

live well,
  vagrant
From 726c21a87f728defba54cc206c42838c73c1032c Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagr...@reproducible-builds.org>
Date: Thu, 6 Oct 2022 17:02:08 +0000
Subject: [PATCH 1/3] debian/rules: Pass --disable-lynx in dh_auto_configure
 override. (Closes: #828752)

Using lynx embeds the build path and sometimes locale-specific
differences in the generated README.
---
 debian/rules | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/debian/rules b/debian/rules
index 0d40890..f211bad 100755
--- a/debian/rules
+++ b/debian/rules
@@ -6,3 +6,6 @@ export DEB_BUILD_MAINT_OPTIONS = hardening=+all
 	dh $@ --with apache2
 
 override_dh_auto_install:
+
+override_dh_auto_configure:
+	dh_auto_configure -- --disable-lynx
-- 
2.30.2

From af404126fb9080662fb2fc67a602334c0d431c9b Mon Sep 17 00:00:00 2001
From: Vagrant Cascadian <vagr...@reproducible-builds.org>
Date: Thu, 6 Oct 2022 17:04:13 +0000
Subject: [PATCH 2/3] debian/control: Remove lynx from Build-Depends.

---
 debian/control | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/debian/control b/debian/control
index d31ca56..ce371f7 100644
--- a/debian/control
+++ b/debian/control
@@ -3,7 +3,7 @@ Section: httpd
 Priority: optional
 Maintainer: Regis Boudin <re...@debian.org>
 Uploaders: Sebastien ESTIENNE <sebastien.estie...@gmail.com>
-Build-Depends: debhelper (>= 10), apache2-dev, dh-apache2,libavahi-client-dev (>= 0.6.4), lynx, libapr1-dev
+Build-Depends: debhelper (>= 10), apache2-dev, dh-apache2,libavahi-client-dev (>= 0.6.4), libapr1-dev
 Standards-Version: 4.1.1
 Homepage: http://0pointer.de/lennart/projects/mod_dnssd/
 
-- 
2.30.2

Attachment: signature.asc
Description: PGP signature

Reply via email to