On 2016-06-28, Reiner Herrmann wrote: > While working on the "reproducible builds" effort [1], we have noticed > that ario could not be built reproducibly. > It embeds the current year into the binary. > > The attached patch replaces it with a static value.
I can confirm this patch is still needed, but when I tried applying this patch, it fails to build asking for automake-1.15 (which is no longer in debian, but automake-1.16 is): Making all in src make[3]: Entering directory '/<<PKGBUILDDIR>>/src' cd .. && /bin/bash /<<PKGBUILDDIR>>/missing automake-1.15 --foreign src/Makefile /<<PKGBUILDDIR>>/missing: line 81: automake-1.15: command not found WARNING: 'automake-1.15' is missing on your system. You should only need it if you modified 'Makefile.am' or 'configure.ac' or m4 files included by 'configure.ac'. Struggling to figure out how to get cdbs to actually regenerate the files with a newer automake... live well, vagrant > [1]: https://wiki.debian.org/ReproducibleBuilds > diff --git a/debian/patches/reproducible-build.patch > b/debian/patches/reproducible-build.patch > new file mode 100644 > index 0000000..9377027 > --- /dev/null > +++ b/debian/patches/reproducible-build.patch > @@ -0,0 +1,26 @@ > +Author: Reiner Herrmann <rei...@reiner-h.de> > +Description: Replace current year with static value to get reproducible build > + > +--- a/src/Makefile.am > ++++ b/src/Makefile.am > +@@ -214,8 +214,7 @@ > + -DDATA_PATH=\""$(pkgdatadir)/data/"\"\ > + -DUI_PATH=\""$(pkgdatadir)/ui/"\"\ > + -DARIO_PLUGIN_DIR=\"$(PLUGINDIR)\"\ > +- -DARIO_PLUGIN_DATA_DIR=\"$(PLUGIN_DATA_DIR)\"\ > +- -DCURRENT_DATE="\"`date +%G`\"" > ++ -DARIO_PLUGIN_DATA_DIR=\"$(PLUGIN_DATA_DIR)\" > + > + if MPD_GLIB > + AM_CPPFLAGS += -DMPD_GLIB > +--- a/src/shell/ario-shell.c > ++++ b/src/shell/ario-shell.c > +@@ -821,7 +821,7 @@ > + "name", "Ario", > + "program-name", "Ario", > + "version", PACKAGE_VERSION, > +- "copyright", "Copyright \xc2\xa9 2005-" > CURRENT_DATE " Marc Pavot", > ++ "copyright", "Copyright \xc2\xa9 2005-2011 > Marc Pavot", > + "comments", _("GTK client for MPD"), > + "translator-credits", > _("translator-credits"), > + "authors", (const char **) authors, > diff --git a/debian/patches/series b/debian/patches/series > index 7e66345..60ef58f 100644 > --- a/debian/patches/series > +++ b/debian/patches/series > @@ -1 +1,2 @@ > glib-single-include.patch > +reproducible-build.patch
signature.asc
Description: PGP signature
