Hi Georges!

On Sun, Oct 02, 2022 at 07:45:44PM +0200, Georges Khaznadar wrote:
> Dear Maintainer,
>
> When I run `gbp buildpackage --git-pbuilder` to check debian packages,
> it fails when pylupdate5 is invoked:
>
> -------------------8<--------------------------
>   File "/usr/lib/python3/dist-packages/PyQt5/pylupdate_main.py", line 73, in
> _encoded_path
>     return path.encode(locale.getdefaultlocale()[1])
> TypeError: encode() argument 'encoding' must be str, not None
> -------------------8<--------------------------
>
> This happens since Python3 became Python3.10: in a cowbuilder shell,
> locale.getdefaultlocale() returns now (None, None), which may be legitimate.
> However it should not prevent pylupdate to make its work. In this case,
> the rigth thing to do might be: `encoding="C"; return path.encode(encoding)`

Thanks for the patch.

What is upstream status of it? Can you forward it (subscribe to the mailing
list [1] and send an email there) or you prefer if I do it?

[1]: https://www.riverbankcomputing.com/mailman/listinfo/pyqt

> I pushed such a change into our Salsa repository, and I shall make an upload 
> to
> DELAYED+15; please feel free to tell me to cancel this upload.
>
> Thank you in advance for any comment.

As you are member of python-team, you can do "Team upload" instead of
"Non-maintainer upload" (with normal version bump).

--
Dmitry Shachnev

Attachment: signature.asc
Description: PGP signature

Reply via email to