Le 22/09/22 à 21:02, Holger Levsen a écrit :
hi Laurent,
Hello Holger,

what do you think of the proposed patch?

for your convinience: (see https://bugs.debian.org/1017372
for more explainations but this is the diff)

Subject: [PATCH] configure.ac: Avoid embedding the date in the version.

Use the version from the last debian/changelog entry, otherwise the
build will differ if built on a different year and week and from git
builds vs. builds from source tarball.
---
  configure.ac | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 6e00c0c..0de1856 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1,5 +1,5 @@
  AC_INIT([plymouth],
-        m4_esyscmd_s([date +%y.%V.$(git rev-list $(git describe 
--abbrev=0)..HEAD --count) || echo 0]),
+        m4_esyscmd_s([dpkg-parsechangelog --show-field Version]),


Thanks for the patch.

I've modified the command line to 'dpkg-parsechangelog --show-field Version | sed -e 's/-[^-]*$//' |  sed -e 's/^[0-9]*://'' to drop the epoch and debian revision from the version, and only keep the upstream one. (inspired from /usr/share/dpkg/pkg-info.mk)

I also opened a bug upstream: https://gitlab.freedesktop.org/plymouth/plymouth/-/issues/188

Kind regards,

Laurent Bigonville

Reply via email to